Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: components/ntp_snippets/ntp_snippets_status_service_unittest.cc

Issue 2158373002: [NTP Snippets] Add a pref to disable the NTPSnippetsService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/ntp_snippets_status_service.h" 5 #include "components/ntp_snippets/ntp_snippets_status_service.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "components/ntp_snippets/ntp_snippets_test_utils.h" 9 #include "components/ntp_snippets/ntp_snippets_test_utils.h"
10 #include "components/ntp_snippets/pref_names.h"
10 #include "components/prefs/pref_registry_simple.h" 11 #include "components/prefs/pref_registry_simple.h"
11 #include "components/prefs/testing_pref_service.h" 12 #include "components/prefs/testing_pref_service.h"
12 #include "components/signin/core/browser/account_tracker_service.h" 13 #include "components/signin/core/browser/account_tracker_service.h"
13 #include "components/signin/core/browser/fake_signin_manager.h" 14 #include "components/signin/core/browser/fake_signin_manager.h"
14 #include "components/signin/core/browser/test_signin_client.h" 15 #include "components/signin/core/browser/test_signin_client.h"
15 #include "components/signin/core/common/signin_pref_names.h" 16 #include "components/signin/core/common/signin_pref_names.h"
16 #include "components/sync_driver/fake_sync_service.h" 17 #include "components/sync_driver/fake_sync_service.h"
17 #include "testing/gmock/include/gmock/gmock.h" 18 #include "testing/gmock/include/gmock/gmock.h"
18 #include "testing/gtest/include/gtest/gtest.h" 19 #include "testing/gtest/include/gtest/gtest.h"
19 20
20 using testing::Return; 21 using testing::Return;
21 22
22 namespace ntp_snippets { 23 namespace ntp_snippets {
23 24
24 class NTPSnippetsStatusServiceTest : public test::NTPSnippetsTestBase { 25 class NTPSnippetsStatusServiceTest : public test::NTPSnippetsTestBase {
25 public: 26 public:
27 NTPSnippetsStatusServiceTest() {
28 NTPSnippetsStatusService::RegisterProfilePrefs(pref_service()->registry());
29 }
30
26 void SetUp() override { 31 void SetUp() override {
27 test::NTPSnippetsTestBase::SetUp(); 32 test::NTPSnippetsTestBase::SetUp();
28 33
29 service_.reset(new NTPSnippetsStatusService(fake_signin_manager(), 34 service_.reset(new NTPSnippetsStatusService(
30 mock_sync_service())); 35 fake_signin_manager(), mock_sync_service(), pref_service()));
31 } 36 }
32 37
33 protected: 38 protected:
34 NTPSnippetsStatusService* service() { return service_.get(); } 39 NTPSnippetsStatusService* service() { return service_.get(); }
35 40
36 private: 41 private:
37 std::unique_ptr<NTPSnippetsStatusService> service_; 42 std::unique_ptr<NTPSnippetsStatusService> service_;
38 }; 43 };
39 44
40 TEST_F(NTPSnippetsStatusServiceTest, SyncStateCompatibility) { 45 TEST_F(NTPSnippetsStatusServiceTest, SyncStateCompatibility) {
(...skipping 19 matching lines...) Expand all
60 mock_sync_service()->active_data_types_ = syncer::ModelTypeSet(); 65 mock_sync_service()->active_data_types_ = syncer::ModelTypeSet();
61 EXPECT_EQ(DisabledReason::HISTORY_SYNC_STATE_UNKNOWN, 66 EXPECT_EQ(DisabledReason::HISTORY_SYNC_STATE_UNKNOWN,
62 service()->GetDisabledReasonFromDeps()); 67 service()->GetDisabledReasonFromDeps());
63 68
64 // Sync disabled. 69 // Sync disabled.
65 mock_sync_service()->can_sync_start_ = false; 70 mock_sync_service()->can_sync_start_ = false;
66 EXPECT_EQ(DisabledReason::SYNC_DISABLED, 71 EXPECT_EQ(DisabledReason::SYNC_DISABLED,
67 service()->GetDisabledReasonFromDeps()); 72 service()->GetDisabledReasonFromDeps());
68 } 73 }
69 74
75 TEST_F(NTPSnippetsStatusServiceTest, DisabledViaPref) {
76 // The default test setup is signed out.
77 ASSERT_EQ(DisabledReason::SIGNED_OUT, service()->GetDisabledReasonFromDeps());
78
79 // Once the disabled pref is set, we should be disabled.
80 pref_service()->SetBoolean(prefs::kDisableSnippets, true);
81 EXPECT_EQ(DisabledReason::EXPLICITLY_DISABLED,
82 service()->GetDisabledReasonFromDeps());
83
84 // The other dependencies shouldn't matter anymore.
85 fake_signin_manager()->SignIn("foo@bar.com");
86 EXPECT_EQ(DisabledReason::EXPLICITLY_DISABLED,
87 service()->GetDisabledReasonFromDeps());
88
89 mock_sync_service()->active_data_types_ = syncer::ModelTypeSet();
90 EXPECT_EQ(DisabledReason::EXPLICITLY_DISABLED,
91 service()->GetDisabledReasonFromDeps());
92
93 mock_sync_service()->is_encrypt_everything_enabled_ = true;
94 EXPECT_EQ(DisabledReason::EXPLICITLY_DISABLED,
95 service()->GetDisabledReasonFromDeps());
96
97 mock_sync_service()->configuration_done_ = false;
98 EXPECT_EQ(DisabledReason::EXPLICITLY_DISABLED,
99 service()->GetDisabledReasonFromDeps());
100
101 mock_sync_service()->can_sync_start_ = false;
102 EXPECT_EQ(DisabledReason::EXPLICITLY_DISABLED,
103 service()->GetDisabledReasonFromDeps());
104 }
105
70 } // namespace ntp_snippets 106 } // namespace ntp_snippets
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698