Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2156173003: Re-land r406064 "[GN] Add JSON project writer". (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land r406064 "[GN] Add JSON project writer". This re-lands the CL with the fixes to the GYP build. TBR=brettw@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win8_chromium_gyp_rel,win8_chromium_gyp_dbg;tryserver.chromium.mac:mac_chromium_gyp_rel,mac_chromium_gyp_dbg Committed: https://crrev.com/05316e06071fc092471af129a926f87b43347321 Cr-Commit-Position: refs/heads/master@{#406165}

Patch Set 1 #

Patch Set 2 : add new files to GYP build #

Patch Set 3 : clear dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1358 lines, -744 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/gn/command_desc.cc View 5 chunks +257 lines, -700 lines 0 comments Download
M tools/gn/command_gen.cc View 10 chunks +55 lines, -9 lines 0 comments Download
M tools/gn/commands.h View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/gn/commands.cc View 6 chunks +35 lines, -22 lines 0 comments Download
A tools/gn/desc_builder.h View 1 chunk +27 lines, -0 lines 0 comments Download
A tools/gn/desc_builder.cc View 1 chunk +694 lines, -0 lines 0 comments Download
M tools/gn/gn.gyp View 1 2 chunks +4 lines, -0 lines 0 comments Download
A tools/gn/json_project_writer.h View 1 chunk +26 lines, -0 lines 0 comments Download
A tools/gn/json_project_writer.cc View 1 chunk +217 lines, -0 lines 0 comments Download
M tools/gn/target.cc View 2 chunks +13 lines, -12 lines 0 comments Download
M tools/gn/visibility.h View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/gn/visibility.cc View 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
This CL has an open dependency (Issue 2158143002 Patch 20001). Please resolve the dependency and ...
4 years, 5 months ago (2016-07-18 21:56:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156173003/40001
4 years, 5 months ago (2016-07-18 22:03:22 UTC) #6
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-18 22:03:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/245975)
4 years, 5 months ago (2016-07-19 00:05:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156173003/40001
4 years, 5 months ago (2016-07-19 00:09:51 UTC) #11
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-19 00:09:53 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-19 00:45:37 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 00:49:07 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/05316e06071fc092471af129a926f87b43347321
Cr-Commit-Position: refs/heads/master@{#406165}

Powered by Google App Engine
This is Rietveld 408576698