Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1550)

Unified Diff: appengine/findit/crash/test/callstack_test.py

Issue 2157433002: [Findit] Pass changed files info to Fracas, 2 face design. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fix nits. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/scorers/top_frame_index.py ('k') | appengine/findit/crash/test/crash_test_suite.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/test/callstack_test.py
diff --git a/appengine/findit/crash/test/callstack_test.py b/appengine/findit/crash/test/callstack_test.py
index 18ff6cf6978b8c30d36f0c53ee172f558083af04..8ca3471a07cb5fedfcd4477fd16f8f28cd938329 100644
--- a/appengine/findit/crash/test/callstack_test.py
+++ b/appengine/findit/crash/test/callstack_test.py
@@ -21,6 +21,16 @@ class CallStackTest(StacktraceTestSuite):
StackFrame(0, 'src/', 'func', 'f.cc', 'src/f.cc', [1, 2]).ToString(),
'#0 in func @ f.cc:1:1')
+ def testBlameUrlForStackFrame(self):
+ frame = StackFrame(0, 'src/', 'func', 'f.cc', 'src/f.cc', [])
+ self.assertEqual(frame.BlameUrl('1'), None)
+
+ frame.repo_url = 'https://repo_url'
+ self.assertEqual(frame.BlameUrl('1'), 'https://repo_url/+blame/1/f.cc')
+
+ frame.crashed_line_numbers = [9, 10]
+ self.assertEqual(frame.BlameUrl('1'), 'https://repo_url/+blame/1/f.cc#9')
+
def testFrameListInitCallStack(self):
stack = CallStack(0)
stack.extend([StackFrame(0, 'src/', '', 'func', 'f.cc', [2])])
« no previous file with comments | « appengine/findit/crash/scorers/top_frame_index.py ('k') | appengine/findit/crash/test/crash_test_suite.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698