Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: appengine/findit/crash/test/crash_test_suite.py

Issue 2157433002: [Findit] Pass changed files info to Fracas, 2 face design. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fix nits. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/test/callstack_test.py ('k') | appengine/findit/crash/test/findit_for_crash_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/test/crash_test_suite.py
diff --git a/appengine/findit/crash/test/crash_test_suite.py b/appengine/findit/crash/test/crash_test_suite.py
index 1b8ab96bdec63e33446c3e7814331eb9f4852b8b..15e28e2f3b4016424e436e8bbaac71bd77284e54 100644
--- a/appengine/findit/crash/test/crash_test_suite.py
+++ b/appengine/findit/crash/test/crash_test_suite.py
@@ -28,18 +28,20 @@ class CrashTestSuite(StacktraceTestSuite): # pragma: no cover.
self._VerifyTwoChangeLogsEqual(result1.changelog, result2.changelog)
self.assertEqual(result1.dep_path, result2.dep_path)
self.assertEqual(result1.confidence, result2.confidence)
- self.assertEqual(result1.reason, result2.reason)
- self.assertEqual(len(result1.file_to_stack_infos),
- len(result2.file_to_stack_infos))
+ self.assertEqual(result1.reasons, result2.reasons)
- for (file_path1, stack_infos1), (file_path2, stack_infos2) in zip(
- result1.file_to_stack_infos.iteritems(),
- result2.file_to_stack_infos.iteritems()):
- self.assertEqual(file_path1, file_path2)
- self._VerifyTwoStackInfosEqual(stack_infos1, stack_infos2)
+ self.assertEqual(result1.file_to_stack_infos.keys(),
+ result2.file_to_stack_infos.keys())
+ for file_path in result1.file_to_stack_infos.keys():
+ self._VerifyTwoStackInfosEqual(result1.file_to_stack_infos[file_path],
+ result2.file_to_stack_infos[file_path])
+
+ self.assertEqual(result1.file_to_analysis_info,
+ result2.file_to_analysis_info)
def _VerifyTwoMatchResultEqual(self, match_result1, match_result2):
- self.assertEqual(match_result1.min_distance, match_result2.min_distance)
+ self.assertEqual(match_result1.file_to_analysis_info,
+ match_result2.file_to_analysis_info)
self._VerifyTwoResultEqual(match_result1, match_result2)
def _VerifyTwoMatchResultsEqual(self, match_results1, match_results2):
« no previous file with comments | « appengine/findit/crash/test/callstack_test.py ('k') | appengine/findit/crash/test/findit_for_crash_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698