Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1853)

Unified Diff: appengine/findit/crash/scorers/top_frame_index.py

Issue 2157433002: [Findit] Pass changed files info to Fracas, 2 face design. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Fix nits. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/scorers/top_frame_index.py
diff --git a/appengine/findit/crash/scorers/top_frame_index.py b/appengine/findit/crash/scorers/top_frame_index.py
index ae0e06c794701f2d0abc7df4923fd74a20b3ac50..77160e9f83eee07f867fc8e9046a973a73775aa6 100644
--- a/appengine/findit/crash/scorers/top_frame_index.py
+++ b/appengine/findit/crash/scorers/top_frame_index.py
@@ -40,6 +40,10 @@ class TopFrameIndex(Scorer):
def Reason(self, top_frame_index, score):
if score == 0:
- return ''
+ return None
+
+ return self.name, score, 'Top frame is #%d' % top_frame_index
- return 'Modified top crashing frame is #%d' % top_frame_index
+ def ChangedFiles(self, result):
+ # There is no changed file infos that top frame scorer can provide.
+ return None
« no previous file with comments | « appengine/findit/crash/scorers/test/top_frame_index_test.py ('k') | appengine/findit/crash/test/callstack_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698