Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 215703002: Remove unused selection related methods from WebView that got moved to WebFrame in r169968 … (Closed)

Created:
6 years, 9 months ago by jam
Modified:
6 years, 9 months ago
Reviewers:
dglazkov
CC:
blink-reviews, jamesr, abarth-chromium, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove unused selection related methods from WebView that got moved to WebFrame in r169968 now that Chrome uses the new ones. BUG=304341 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170272

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
M Source/web/WebViewImpl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +0 lines, -40 lines 0 comments Download
M public/web/WebView.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
jam
6 years, 9 months ago (2014-03-27 22:38:39 UTC) #1
dglazkov
lgtm my favorite kind of patches.
6 years, 9 months ago (2014-03-27 22:39:10 UTC) #2
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-27 23:01:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/215703002/1
6 years, 9 months ago (2014-03-27 23:01:44 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:05:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 23:05:12 UTC) #6
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-27 23:11:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/215703002/1
6 years, 9 months ago (2014-03-27 23:11:34 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:15:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 23:15:30 UTC) #10
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-27 23:16:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/215703002/1
6 years, 9 months ago (2014-03-27 23:16:16 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:48:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-27 23:48:45 UTC) #14
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-28 00:11:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/215703002/1
6 years, 9 months ago (2014-03-28 00:11:40 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 01:25:39 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-28 01:25:40 UTC) #18
jam
The CQ bit was checked by jam@chromium.org
6 years, 9 months ago (2014-03-28 04:28:36 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/215703002/1
6 years, 9 months ago (2014-03-28 04:28:41 UTC) #20
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 05:32:17 UTC) #21
Message was sent while issue was closed. 
Change committed as 170272

Powered by Google App Engine
This is Rietveld 408576698