Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 215703002: Remove unused selection related methods from WebView that got moved to WebFrame in r169968 … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebViewImpl.h ('k') | public/web/WebView.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index 9bbc57e15937f157cf554080c4cbd57548f8581a..f169cdccb06b52d4dac8a51dce2eee729ee9e66d 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -2237,34 +2237,6 @@ bool WebViewImpl::isSelectionAnchorFirst() const
return false;
}
-bool WebViewImpl::setEditableSelectionOffsets(int start, int end)
-{
- const LocalFrame* focused = focusedWebCoreFrame();
- if (!focused)
- return false;
- return focused->inputMethodController().setEditableSelectionOffsets(PlainTextRange(start, end));
-}
-
-bool WebViewImpl::setCompositionFromExistingText(int compositionStart, int compositionEnd, const WebVector<WebCompositionUnderline>& underlines)
-{
- const LocalFrame* focused = focusedWebCoreFrame();
- if (!focused)
- return false;
-
- if (!focused->editor().canEdit())
- return false;
-
- InputMethodController& inputMethodController = focused->inputMethodController();
- inputMethodController.cancelComposition();
-
- if (compositionStart == compositionEnd)
- return true;
-
- inputMethodController.setCompositionFromExistingText(CompositionUnderlineVectorBuilder(underlines), compositionStart, compositionEnd);
-
- return true;
-}
-
WebVector<WebCompositionUnderline> WebViewImpl::compositionUnderlines() const
{
const LocalFrame* focused = focusedWebCoreFrame();
@@ -2279,18 +2251,6 @@ WebVector<WebCompositionUnderline> WebViewImpl::compositionUnderlines() const
return results;
}
-void WebViewImpl::extendSelectionAndDelete(int before, int after)
-{
- LocalFrame* focused = focusedWebCoreFrame();
- if (!focused)
- return;
- if (WebPlugin* plugin = focusedPluginIfInputMethodSupported(focused)) {
- plugin->extendSelectionAndDelete(before, after);
- return;
- }
- focused->inputMethodController().extendSelectionAndDelete(before, after);
-}
-
WebColor WebViewImpl::backgroundColor() const
{
if (isTransparent())
« no previous file with comments | « Source/web/WebViewImpl.h ('k') | public/web/WebView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698