Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: Source/web/WebViewImpl.h

Issue 215703002: Remove unused selection related methods from WebView that got moved to WebFrame in r169968 … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 virtual bool setComposition( 143 virtual bool setComposition(
144 const WebString& text, 144 const WebString& text,
145 const WebVector<WebCompositionUnderline>& underlines, 145 const WebVector<WebCompositionUnderline>& underlines,
146 int selectionStart, 146 int selectionStart,
147 int selectionEnd) OVERRIDE; 147 int selectionEnd) OVERRIDE;
148 virtual bool confirmComposition() OVERRIDE; 148 virtual bool confirmComposition() OVERRIDE;
149 virtual bool confirmComposition(ConfirmCompositionBehavior selectionBehavior ) OVERRIDE; 149 virtual bool confirmComposition(ConfirmCompositionBehavior selectionBehavior ) OVERRIDE;
150 virtual bool confirmComposition(const WebString& text) OVERRIDE; 150 virtual bool confirmComposition(const WebString& text) OVERRIDE;
151 virtual bool compositionRange(size_t* location, size_t* length) OVERRIDE; 151 virtual bool compositionRange(size_t* location, size_t* length) OVERRIDE;
152 virtual WebTextInputInfo textInputInfo() OVERRIDE; 152 virtual WebTextInputInfo textInputInfo() OVERRIDE;
153 virtual bool setEditableSelectionOffsets(int start, int end) OVERRIDE;
154 virtual bool setCompositionFromExistingText(int compositionStart, int compos itionEnd, const WebVector<WebCompositionUnderline>& underlines) OVERRIDE;
155 virtual void extendSelectionAndDelete(int before, int after) OVERRIDE;
156 virtual WebColor backgroundColor() const OVERRIDE; 153 virtual WebColor backgroundColor() const OVERRIDE;
157 virtual bool selectionBounds(WebRect& anchor, WebRect& focus) const OVERRIDE ; 154 virtual bool selectionBounds(WebRect& anchor, WebRect& focus) const OVERRIDE ;
158 virtual void didShowCandidateWindow() OVERRIDE; 155 virtual void didShowCandidateWindow() OVERRIDE;
159 virtual void didUpdateCandidateWindow() OVERRIDE; 156 virtual void didUpdateCandidateWindow() OVERRIDE;
160 virtual void didHideCandidateWindow() OVERRIDE; 157 virtual void didHideCandidateWindow() OVERRIDE;
161 virtual bool selectionTextDirection(WebTextDirection& start, WebTextDirectio n& end) const OVERRIDE; 158 virtual bool selectionTextDirection(WebTextDirection& start, WebTextDirectio n& end) const OVERRIDE;
162 virtual bool isSelectionAnchorFirst() const OVERRIDE; 159 virtual bool isSelectionAnchorFirst() const OVERRIDE;
163 virtual bool caretOrSelectionRange(size_t* location, size_t* length) OVERRID E; 160 virtual bool caretOrSelectionRange(size_t* location, size_t* length) OVERRID E;
164 virtual void setTextDirection(WebTextDirection) OVERRIDE; 161 virtual void setTextDirection(WebTextDirection) OVERRIDE;
165 virtual bool isAcceleratedCompositingActive() const OVERRIDE; 162 virtual bool isAcceleratedCompositingActive() const OVERRIDE;
(...skipping 604 matching lines...) Expand 10 before | Expand all | Expand 10 after
770 float m_zoomFactorOverride; 767 float m_zoomFactorOverride;
771 }; 768 };
772 769
773 // We have no ways to check if the specified WebView is an instance of 770 // We have no ways to check if the specified WebView is an instance of
774 // WebViewImpl because WebViewImpl is the only implementation of WebView. 771 // WebViewImpl because WebViewImpl is the only implementation of WebView.
775 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true); 772 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
776 773
777 } // namespace blink 774 } // namespace blink
778 775
779 #endif 776 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698