archive_build.py: use absolute path to src dir to construct build dir

archive_build.py: use absolute path to src dir to construct build dir

BUG=593999, 584079
Committed: https://chromium.googlesource.com/chromium/tools/build/+/4851591b771f2e668a5b275d12dd856e3cfb922d

[Paweł Hajdan Jr., 2016-07-18 14:13:23]

phajdan.jr@chromium.org changed reviewers:
+ emso@chromium.org, sergiyb@chromium.org, tandrii@chromium.org

[Paweł Hajdan Jr., 2016-07-18 14:13:23]

Example failure:
https://build.chromium.org/p/chromium/builders/Win/builds/45328/steps/archive...
:

Staging in C:\b\c\chrome_staging
last change: 405981
Traceback (most recent call last):
  File "C:\b\rr\tmprd1xvm\rw\checkout\scripts\slave\chromium\archive_build.py",
line 672, in <module>
    sys.exit(main())
  File "C:\b\rr\tmprd1xvm\rw\checkout\scripts\slave\chromium\archive_build.py",
line 668, in main
    return s.ArchiveBuild()
  File "C:\b\rr\tmprd1xvm\rw\checkout\scripts\slave\chromium\archive_build.py",
line 492, in ArchiveBuild
    os.path.join(self._staging_dir, stage_subdir), dest_fn=stage_fn)
  File "C:\b\build\scripts\common\chromium_utils.py", line 587, in CopyFileToDir
build name: Win
Creating archive chrome-win32.zip ...
WARNING: No files to archive.
chromium_utils.CopyFileToDir(src\out\Release\mini_installer.exe,
C:\b\c\chrome_staging\, dest_fn=mini_installer.exe)
    raise PathNotFound('Unable to find file %s' % src_path)
common.chromium_utils.PathNotFound: Unable to find file
src\out\Release\mini_installer.exe
step returned non-zero exit code: 1

[Paweł Hajdan Jr., 2016-07-18 14:13:29]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 14:13:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sergiy Byelozyorov, 2016-07-18 14:15:18]

lgtm

[Paweł Hajdan Jr., 2016-07-18 14:16:19]

The CQ bit was unchecked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-07-18 14:16:21]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2016-07-18 14:16:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2016-07-18 14:18:34]

https://codereview.chromium.org/2156983002/diff/1/scripts/slave/chromium/arch...
File scripts/slave/chromium/archive_build.py (right):

https://codereview.chromium.org/2156983002/diff/1/scripts/slave/chromium/arch...
scripts/slave/chromium/archive_build.py:68: build_dir =
build_directory.GetBuildOutputDirectory(self._src_dir or None)
can _src_dir actually be '' or False? If not, remove "or None"

[Paweł Hajdan Jr., 2016-07-18 14:20:27]

https://codereview.chromium.org/2156983002/diff/1/scripts/slave/chromium/arch...
File scripts/slave/chromium/archive_build.py (right):

https://codereview.chromium.org/2156983002/diff/1/scripts/slave/chromium/arch...
scripts/slave/chromium/archive_build.py:68: build_dir =
build_directory.GetBuildOutputDirectory(self._src_dir or None)
On 2016/07/18 at 14:18:34, tandrii(chromium) wrote:
> can _src_dir actually be '' or False? If not, remove "or None"

It might be empty, and GetBuildOutputDirectory does an "is None" check.

[commit-bot: I haz the power, 2016-07-18 14:21:15]

Description was changed from

==========
archive_build.py: use absolute path to src dir to construct build dir

BUG=593999, 584079
==========

to

==========
archive_build.py: use absolute path to src dir to construct build dir

BUG=593999, 584079

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/4851591b771f2e668a5b...
==========

[commit-bot: I haz the power, 2016-07-18 14:21:16]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/4851591b771f2e668a5b...

[tandrii(chromium), 2016-07-18 14:21:41]

https://codereview.chromium.org/2156983002/diff/1/scripts/slave/chromium/arch...
File scripts/slave/chromium/archive_build.py (right):

https://codereview.chromium.org/2156983002/diff/1/scripts/slave/chromium/arch...
scripts/slave/chromium/archive_build.py:68: build_dir =
build_directory.GetBuildOutputDirectory(self._src_dir or None)
On 2016/07/18 14:20:27, Paweł Hajdan Jr. wrote:
> On 2016/07/18 at 14:18:34, tandrii(chromium) wrote:
> > can _src_dir actually be '' or False? If not, remove "or None"
> 
> It might be empty, and GetBuildOutputDirectory does an "is None" check.

assuming by empty you mean '', OK.