archive_build.py: use absolute path to src dir to construct build dir

scripts/slave/chromium/archive_build.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A tool to archive a build and its symbols, executed by a buildbot slave.
 
   This script is used for developer builds.
 
   To archive files on Google Storage, set the 'gs_bucket' key in the
@@ skipping 47 matching lines @@
 class StagerBase(object):
   """Handles archiving a build. Call the public ArchiveBuild() method."""
 
   def __init__(self, options, build_revision):
     """Sets a number of file and directory paths for convenient use."""
 
     self.options = options
     self._src_dir = os.path.abspath(options.src_dir)
     self._chrome_dir = os.path.join(self._src_dir, 'chrome')
 
-    build_dir = build_directory.GetBuildOutputDirectory()
+    build_dir = build_directory.GetBuildOutputDirectory(self._src_dir or None)

[tandrii(chromium), 2016/07/18 14:18:34]

can _src_dir actually be '' or False? If not, remove "or None"

[Paweł Hajdan Jr., 2016/07/18 14:20:27]

It might be empty, and GetBuildOutputDirectory does an "is None" check.

[tandrii(chromium), 2016/07/18 14:21:41]

assuming by empty you mean '', OK.

     self._build_dir = os.path.join(build_dir, options.target)
     if chromium_utils.IsWindows():
       self._tool_dir = os.path.join(self._chrome_dir, 'tools', 'build', 'win')
     elif chromium_utils.IsLinux():
       # On Linux, we might have built for chromeos.  Archive the same.
       if (options.factory_properties.get('chromeos', None) or
           slave_utils.GypFlagIsOn(options, 'chromeos')):
         self._tool_dir = os.path.join(self._chrome_dir, 'tools', 'build',
                                       'chromeos')
       # Or, we might have built for Android.
@@ skipping 584 matching lines @@
 
   if options.build_number is not None:
     s = StagerByBuildNumber(options)
   else:
     s = StagerByChromiumRevision(options)
   return s.ArchiveBuild()
 
 
 if '__main__' == __name__:
   sys.exit(main())