Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: scripts/slave/chromium/archive_build.py

Issue 2156983002: archive_build.py: use absolute path to src dir to construct build dir (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/chromium/archive_build.py
diff --git a/scripts/slave/chromium/archive_build.py b/scripts/slave/chromium/archive_build.py
index 139ce2e0abe863d63cf19b39f2eea042cd069b1c..83c8521848598f6c403bb27b2d6861be4af52b6f 100755
--- a/scripts/slave/chromium/archive_build.py
+++ b/scripts/slave/chromium/archive_build.py
@@ -65,7 +65,7 @@ class StagerBase(object):
self._src_dir = os.path.abspath(options.src_dir)
self._chrome_dir = os.path.join(self._src_dir, 'chrome')
- build_dir = build_directory.GetBuildOutputDirectory()
+ build_dir = build_directory.GetBuildOutputDirectory(self._src_dir or None)
tandrii(chromium) 2016/07/18 14:18:34 can _src_dir actually be '' or False? If not, remo
Paweł Hajdan Jr. 2016/07/18 14:20:27 It might be empty, and GetBuildOutputDirectory doe
tandrii(chromium) 2016/07/18 14:21:41 assuming by empty you mean '', OK.
self._build_dir = os.path.join(build_dir, options.target)
if chromium_utils.IsWindows():
self._tool_dir = os.path.join(self._chrome_dir, 'tools', 'build', 'win')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698