Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 2156333002: Mac: Clean up visibility state tracking (Closed)

Created:
4 years, 5 months ago by ccameron
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, James Su, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Mac: Clean up visibility state tracking Trying to fix this has been a source of hung frames. This makes the DelegatedFrameHostClient's IsVisible callback return the variable that tracks whether or not the DelegatedFrameHost's owner has set it to be visible. BUG=623716 Review-Url: https://codereview.chromium.org/2125143004 Cr-Commit-Position: refs/heads/master@{#404469} (cherry picked from commit 4309d664520802fe54ba603622b1222741e427aa) Mac: Further clean up RWHVMac<->DelegatedFrameHost This removes the strangeness whereby the BrowserCompositorMac would own the DelegatedFrameHost, but its owner, the RenderWidgetHostViewMac, would be the DelegatedFrameHostClient. BUG=625610 Review-Url: https://codereview.chromium.org/2123313002 Cr-Commit-Position: refs/heads/master@{#404006} (cherry picked from commit 69170b87c992e07df18559ba1a50fb9b41a5988b) Remove more GpuMemoryBufferId plumbing This is not used anymore. BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2129523003 Cr-Commit-Position: refs/heads/master@{#404001} (cherry picked from commit 1b0250ffc474bcd610e3109d33ece7fa4e87eeca) Committed: https://chromium.googlesource.com/chromium/src/+/1dee73bd817af4a1b6ca0bfc84f37a6d276787dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -252 lines) Patch
M cc/resources/resource_provider.h View 2 chunks +1 line, -3 lines 0 comments Download
M cc/resources/resource_provider.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 18 chunks +35 lines, -52 lines 0 comments Download
M cc/surfaces/surface.h View 2 chunks +0 lines, -5 lines 0 comments Download
M cc/surfaces/surface.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/surfaces/surface_factory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/surfaces/surface_factory.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/browser_compositor_view_mac.h View 7 chunks +54 lines, -11 lines 0 comments Download
M content/browser/renderer_host/browser_compositor_view_mac.mm View 8 chunks +106 lines, -24 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 4 chunks +11 lines, -30 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 8 chunks +18 lines, -92 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ccameron
4 years, 5 months ago (2016-07-18 19:08:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1dee73bd817af4a1b6ca0bfc84f37a6d276787dd.

Powered by Google App Engine
This is Rietveld 408576698