Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2156053002: Revert of New PaintController under-invalidation checking (Closed)

Created:
4 years, 5 months ago by grt (UTC plus 2)
Modified:
4 years, 5 months ago
Reviewers:
chrishtr, Xianzhu, pdr.
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@CommitOnTheWay
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of New PaintController under-invalidation checking (patchset #7 id:120001 of https://codereview.chromium.org/2114653003/ ) Reason for revert: NOTREACHED being hit in checkUnderInvalidation on WebKit Win7 (dbg); see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6481. Original issue's description: > New PaintController under-invalidation checking > > This is a follow-up of https://codereview.chromium.org/2107103002/ > which broke the original under-invalidation checking in > PaintController. > > BUG=596983, 510908 > > Committed: https://crrev.com/63b12484f2c59ba177a21aba09b8a4edd38e6ea1 > Cr-Commit-Position: refs/heads/master@{#405805} TBR=chrishtr@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=596983, 510908 Committed: https://crrev.com/f2f05c78616f02157cd1414905a8692f227d9a64 Cr-Commit-Position: refs/heads/master@{#405988}

Patch Set 1 #

Messages

Total messages: 12 (4 generated)
grt (UTC plus 2)
Created Revert of New PaintController under-invalidation checking
4 years, 5 months ago (2016-07-18 10:53:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156053002/1
4 years, 5 months ago (2016-07-18 10:53:48 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/54097)
4 years, 5 months ago (2016-07-18 12:27:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156053002/1
4 years, 5 months ago (2016-07-18 13:36:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 14:47:26 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 14:47:34 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f2f05c78616f02157cd1414905a8692f227d9a64 Cr-Commit-Position: refs/heads/master@{#405988}
4 years, 5 months ago (2016-07-18 14:51:57 UTC) #11
Xianzhu
4 years, 5 months ago (2016-07-18 16:50:24 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2162603002/ by wangxianzhu@chromium.org.

The reason for reverting is: The original CL is to discover such bugs. Will mark
the test failure in the reland..

Powered by Google App Engine
This is Rietveld 408576698