third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js - Issue 2156053002: Revert of New PaintController under-invalidation checking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js

Issue 2156053002: Revert of New PaintController under-invalidation checking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@CommitOnTheWay

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/fast/repaint/resources/window-resize-repaint.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js

diff --git a/third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js b/third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js

index 93ce90de5005a2ddfc7aad27197f6a2ab9cb9cbc..17802e7586d85fb00e79903ace38b3602c0dafcc 100644

--- a/third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js

+++ b/third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js

@@ -9,7 +9,12 @@

if (window.internals) {

internals.settings.setUseDefaultImageInterpolationQuality(true);

- internals.runtimeFlags.slimmingPaintUnderInvalidationCheckingEnabled = true;

+ // TODO(wangxianzhu): Some spv2 tests crash with under-invalidation-checking

+ // because the extra display items between Subsequence/EndSubsequence for

+ // under-invalidation checking breaks paint chunks. Should fix this when fixing

+ // crbug.com/596983.

+ if (!internals.runtimeFlags.slimmingPaintV2Enabled)

+ internals.runtimeFlags.slimmingPaintUnderInvalidationCheckingEnabled = true;

}

function runRepaintTest()