Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 21560002: Store transition on HStoreNamedField as HConstant. (Closed)

Created:
7 years, 4 months ago by Michael Starzinger
Modified:
7 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Store transition on HStoreNamedField as HConstant. This allows optimization passes that run in the parallel compiler thread to use the map that a store transitions to for further analysis even though the map handle cannot be dereferenced. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -32 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 4 chunks +24 lines, -18 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 4 months ago (2013-08-01 14:26:08 UTC) #1
Jakob Kummerow
lgtm
7 years, 4 months ago (2013-08-02 08:28:18 UTC) #2
Michael Starzinger
7 years, 4 months ago (2013-08-02 11:25:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16028 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698