Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: src/hydrogen.cc

Issue 21560002: Store transition on HStoreNamedField as HConstant. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4536 matching lines...) Expand 10 before | Expand all | Expand 10 after
4547 HObjectAccess::ForHeapNumberValue(), 4547 HObjectAccess::ForHeapNumberValue(),
4548 value); 4548 value);
4549 } 4549 }
4550 } else { 4550 } else {
4551 // This is a normal store. 4551 // This is a normal store.
4552 instr = New<HStoreNamedField>(object, field_access, value); 4552 instr = New<HStoreNamedField>(object, field_access, value);
4553 } 4553 }
4554 4554
4555 if (transition_to_field) { 4555 if (transition_to_field) {
4556 Handle<Map> transition(lookup->GetTransitionMapFromMap(*map)); 4556 Handle<Map> transition(lookup->GetTransitionMapFromMap(*map));
4557 instr->SetTransition(transition, top_info()); 4557 HConstant* transition_constant = Add<HConstant>(transition);
4558 instr->SetTransition(transition_constant, top_info());
4558 // TODO(fschneider): Record the new map type of the object in the IR to 4559 // TODO(fschneider): Record the new map type of the object in the IR to
4559 // enable elimination of redundant checks after the transition store. 4560 // enable elimination of redundant checks after the transition store.
4560 instr->SetGVNFlag(kChangesMaps); 4561 instr->SetGVNFlag(kChangesMaps);
4561 } 4562 }
4562 return instr; 4563 return instr;
4563 } 4564 }
4564 4565
4565 4566
4566 HInstruction* HOptimizedGraphBuilder::BuildStoreNamedGeneric( 4567 HInstruction* HOptimizedGraphBuilder::BuildStoreNamedGeneric(
4567 HValue* object, 4568 HValue* object,
(...skipping 5231 matching lines...) Expand 10 before | Expand all | Expand 10 after
9799 if (ShouldProduceTraceOutput()) { 9800 if (ShouldProduceTraceOutput()) {
9800 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 9801 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
9801 } 9802 }
9802 9803
9803 #ifdef DEBUG 9804 #ifdef DEBUG
9804 graph_->Verify(false); // No full verify. 9805 graph_->Verify(false); // No full verify.
9805 #endif 9806 #endif
9806 } 9807 }
9807 9808
9808 } } // namespace v8::internal 9809 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698