Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 21560002: Store transition on HStoreNamedField as HConstant. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/mips/lithium-mips.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2400 matching lines...) Expand 10 before | Expand all | Expand 10 after
2411 new(zone()) LTrapAllocationMemento(object, temp); 2411 new(zone()) LTrapAllocationMemento(object, temp);
2412 return AssignEnvironment(result); 2412 return AssignEnvironment(result);
2413 } 2413 }
2414 2414
2415 2415
2416 LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) { 2416 LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) {
2417 bool is_in_object = instr->access().IsInobject(); 2417 bool is_in_object = instr->access().IsInobject();
2418 bool is_external_location = instr->access().IsExternalMemory() && 2418 bool is_external_location = instr->access().IsExternalMemory() &&
2419 instr->access().offset() == 0; 2419 instr->access().offset() == 0;
2420 bool needs_write_barrier = instr->NeedsWriteBarrier(); 2420 bool needs_write_barrier = instr->NeedsWriteBarrier();
2421 bool needs_write_barrier_for_map = !instr->transition().is_null() && 2421 bool needs_write_barrier_for_map = instr->has_transition() &&
2422 instr->NeedsWriteBarrierForMap(); 2422 instr->NeedsWriteBarrierForMap();
2423 2423
2424 LOperand* obj; 2424 LOperand* obj;
2425 if (needs_write_barrier) { 2425 if (needs_write_barrier) {
2426 obj = is_in_object 2426 obj = is_in_object
2427 ? UseRegister(instr->object()) 2427 ? UseRegister(instr->object())
2428 : UseTempRegister(instr->object()); 2428 : UseTempRegister(instr->object());
2429 } else if (is_external_location) { 2429 } else if (is_external_location) {
2430 ASSERT(!is_in_object); 2430 ASSERT(!is_in_object);
2431 ASSERT(!needs_write_barrier); 2431 ASSERT(!needs_write_barrier);
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
2745 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2745 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2746 LOperand* object = UseRegister(instr->object()); 2746 LOperand* object = UseRegister(instr->object());
2747 LOperand* index = UseTempRegister(instr->index()); 2747 LOperand* index = UseTempRegister(instr->index());
2748 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2748 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2749 } 2749 }
2750 2750
2751 2751
2752 } } // namespace v8::internal 2752 } } // namespace v8::internal
2753 2753
2754 #endif // V8_TARGET_ARCH_IA32 2754 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/mips/lithium-mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698