Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2155323003: [turbofan] Properly handle bit->float64 representation changes. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly handle bit->float64 representation changes. BUG=chromium:629062 R=jarin@chromium.org Committed: https://crrev.com/15f99cd5b580cd271af15fb72273ba97e6005eaf Cr-Commit-Position: refs/heads/master@{#37853}

Patch Set 1 #

Patch Set 2 : Uncement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M src/compiler/representation-change.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-629062.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-19 04:45:16 UTC) #1
Jarin
lgtm
4 years, 5 months ago (2016-07-19 08:13:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155323003/20001
4 years, 5 months ago (2016-07-19 08:25:39 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 08:28:00 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 08:30:04 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/15f99cd5b580cd271af15fb72273ba97e6005eaf
Cr-Commit-Position: refs/heads/master@{#37853}

Powered by Google App Engine
This is Rietveld 408576698