Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: test/cctest/compiler/test-representation-change.cc

Issue 2155323003: [turbofan] Properly handle bit->float64 representation changes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Uncement Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/representation-change.cc ('k') | test/mjsunit/regress/regress-crbug-629062.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits> 5 #include <limits>
6 6
7 #include "test/cctest/cctest.h" 7 #include "test/cctest/cctest.h"
8 #include "test/cctest/compiler/codegen-tester.h" 8 #include "test/cctest/compiler/codegen-tester.h"
9 #include "test/cctest/compiler/graph-builder-tester.h" 9 #include "test/cctest/compiler/graph-builder-tester.h"
10 #include "test/cctest/compiler/value-helper.h" 10 #include "test/cctest/compiler/value-helper.h"
(...skipping 639 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 r.CheckTypeError(MachineRepresentation::kWord16, Type::None(), 650 r.CheckTypeError(MachineRepresentation::kWord16, Type::None(),
651 MachineRepresentation::kBit); 651 MachineRepresentation::kBit);
652 r.CheckTypeError(MachineRepresentation::kWord32, Type::None(), 652 r.CheckTypeError(MachineRepresentation::kWord32, Type::None(),
653 MachineRepresentation::kBit); 653 MachineRepresentation::kBit);
654 r.CheckTypeError(MachineRepresentation::kWord64, Type::None(), 654 r.CheckTypeError(MachineRepresentation::kWord64, Type::None(),
655 MachineRepresentation::kBit); 655 MachineRepresentation::kBit);
656 656
657 // Floats cannot be implicitly converted to/from comparison conditions. 657 // Floats cannot be implicitly converted to/from comparison conditions.
658 r.CheckTypeError(MachineRepresentation::kFloat64, Type::None(), 658 r.CheckTypeError(MachineRepresentation::kFloat64, Type::None(),
659 MachineRepresentation::kBit); 659 MachineRepresentation::kBit);
660 r.CheckTypeError(MachineRepresentation::kBit, Type::None(),
661 MachineRepresentation::kFloat64);
662 r.CheckTypeError(MachineRepresentation::kBit, Type::Boolean(),
663 MachineRepresentation::kFloat64);
664 660
665 // Floats cannot be implicitly converted to/from comparison conditions. 661 // Floats cannot be implicitly converted to/from comparison conditions.
666 r.CheckTypeError(MachineRepresentation::kFloat32, Type::None(), 662 r.CheckTypeError(MachineRepresentation::kFloat32, Type::None(),
667 MachineRepresentation::kBit); 663 MachineRepresentation::kBit);
668 r.CheckTypeError(MachineRepresentation::kBit, Type::None(), 664 r.CheckTypeError(MachineRepresentation::kBit, Type::None(),
669 MachineRepresentation::kFloat32); 665 MachineRepresentation::kFloat32);
670 r.CheckTypeError(MachineRepresentation::kBit, Type::Boolean(), 666 r.CheckTypeError(MachineRepresentation::kBit, Type::Boolean(),
671 MachineRepresentation::kFloat32); 667 MachineRepresentation::kFloat32);
672 668
673 // Word64 is internal and shouldn't be implicitly converted. 669 // Word64 is internal and shouldn't be implicitly converted.
(...skipping 11 matching lines...) Expand all
685 MachineRepresentation::kWord64); 681 MachineRepresentation::kWord64);
686 r.CheckTypeError(MachineRepresentation::kWord32, Type::Signed32(), 682 r.CheckTypeError(MachineRepresentation::kWord32, Type::Signed32(),
687 MachineRepresentation::kWord64); 683 MachineRepresentation::kWord64);
688 r.CheckTypeError(MachineRepresentation::kWord32, Type::Unsigned32(), 684 r.CheckTypeError(MachineRepresentation::kWord32, Type::Unsigned32(),
689 MachineRepresentation::kWord64); 685 MachineRepresentation::kWord64);
690 } 686 }
691 687
692 } // namespace compiler 688 } // namespace compiler
693 } // namespace internal 689 } // namespace internal
694 } // namespace v8 690 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/representation-change.cc ('k') | test/mjsunit/regress/regress-crbug-629062.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698