test/cctest/compiler/test-representation-change.cc - Issue 2155323003: [turbofan] Properly handle bit->float64 representation changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/compiler/test-representation-change.cc

Issue 2155323003: [turbofan] Properly handle bit->float64 representation changes. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Uncement Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/compiler/test-representation-change.cc

diff --git a/test/cctest/compiler/test-representation-change.cc b/test/cctest/compiler/test-representation-change.cc

index 0d6b5b282708118f4fb74fc29bfbf6319fe29806..8d70ca23d9e096cda0007d7e5720f897459dfa73 100644

--- a/test/cctest/compiler/test-representation-change.cc

+++ b/test/cctest/compiler/test-representation-change.cc

@@ -657,10 +657,6 @@ TEST(TypeErrors) {

// Floats cannot be implicitly converted to/from comparison conditions.

r.CheckTypeError(MachineRepresentation::kFloat64, Type::None(),

MachineRepresentation::kBit);

- r.CheckTypeError(MachineRepresentation::kBit, Type::None(),

- MachineRepresentation::kFloat64);

- r.CheckTypeError(MachineRepresentation::kBit, Type::Boolean(),

- MachineRepresentation::kFloat64);

// Floats cannot be implicitly converted to/from comparison conditions.

r.CheckTypeError(MachineRepresentation::kFloat32, Type::None(),

« no previous file with comments | « src/compiler/representation-change.cc ('k') | test/mjsunit/regress/regress-crbug-629062.js » ('j') | no next file with comments »