Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2155263002: DevTools: Rename StylesPopoverHelper to SwatchPopoverHelper (Closed)

Created:
4 years, 5 months ago by flandy
Modified:
4 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Rename StylesPopoverHelper to SwatchPopoverHelper Also, reposition scroll functionality from the popover helper to the ColorSwatchPopoverIcon/BezierPopoverIcon. This will allow us to move the popover helper so it can be re-used in Sources. BUG=none R=lushnikov Committed: https://crrev.com/19100e605214ca3cc5914d583599c4cc7381e1da Cr-Commit-Position: refs/heads/master@{#406087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -34 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js View 14 chunks +46 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 5 chunks +7 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
flandy
Please take a look
4 years, 5 months ago (2016-07-18 18:22:15 UTC) #1
lushnikov
lgtm nit: please, add a new line after issue title
4 years, 5 months ago (2016-07-18 18:47:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155263002/1
4 years, 5 months ago (2016-07-18 19:09:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 20:46:04 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 20:46:08 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 20:48:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19100e605214ca3cc5914d583599c4cc7381e1da
Cr-Commit-Position: refs/heads/master@{#406087}

Powered by Google App Engine
This is Rietveld 408576698