Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js

Issue 2155263002: DevTools: Rename StylesPopoverHelper to SwatchPopoverHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js b/third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js
index 1f09c124c9b17abd9ca923c93794ddbdad6c7076..e854f7757f0ff688b36260d3a8050b1ed29ce71e 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js
@@ -6,7 +6,7 @@
* @constructor
* @extends {WebInspector.Object}
*/
-WebInspector.StylesPopoverHelper = function()
+WebInspector.SwatchPopoverHelper = function()
{
this._popover = new WebInspector.Popover();
this._popover.setCanShrink(false);
@@ -15,11 +15,10 @@ WebInspector.StylesPopoverHelper = function()
this._hideProxy = this.hide.bind(this, true);
this._boundOnKeyDown = this._onKeyDown.bind(this);
- this._repositionBound = this.reposition.bind(this);
this._boundFocusOut = this._onFocusOut.bind(this);
}
-WebInspector.StylesPopoverHelper.prototype = {
+WebInspector.SwatchPopoverHelper.prototype = {
/**
* @param {!Event} event
*/
@@ -63,16 +62,9 @@ WebInspector.StylesPopoverHelper.prototype = {
document.addEventListener("mousedown", this._hideProxy, false);
document.defaultView.addEventListener("resize", this._hideProxy, false);
this._view.contentElement.addEventListener("keydown", this._boundOnKeyDown, false);
-
- this._scrollerElement = anchorElement.enclosingNodeOrSelfWithClass("style-panes-wrapper");
- if (this._scrollerElement)
- this._scrollerElement.addEventListener("scroll", this._repositionBound, false);
},
- /**
- * @param {!Event=} event
- */
- reposition: function(event)
+ reposition: function()
{
if (!this._previousFocusElement)
this._previousFocusElement = WebInspector.currentFocusElement();
@@ -94,9 +86,6 @@ WebInspector.StylesPopoverHelper.prototype = {
this._isHidden = true;
this._popover.hide();
- if (this._scrollerElement)
- this._scrollerElement.removeEventListener("scroll", this._repositionBound, false);
-
document.removeEventListener("mousedown", this._hideProxy, false);
document.defaultView.removeEventListener("resize", this._hideProxy, false);
@@ -136,16 +125,17 @@ WebInspector.StylesPopoverHelper.prototype = {
/**
* @constructor
* @param {!WebInspector.StylePropertyTreeElement} treeElement
- * @param {!WebInspector.StylesPopoverHelper} stylesPopoverHelper
+ * @param {!WebInspector.SwatchPopoverHelper} swatchPopoverHelper
* @param {string} text
*/
-WebInspector.BezierPopoverIcon = function(treeElement, stylesPopoverHelper, text)
+WebInspector.BezierPopoverIcon = function(treeElement, swatchPopoverHelper, text)
{
this._treeElement = treeElement;
- this._stylesPopoverHelper = stylesPopoverHelper;
+ this._swatchPopoverHelper = swatchPopoverHelper;
this._createDOM(text);
this._boundBezierChanged = this._bezierChanged.bind(this);
+ this._boundOnScroll = this._onScroll.bind(this);
}
WebInspector.BezierPopoverIcon.prototype = {
@@ -184,8 +174,8 @@ WebInspector.BezierPopoverIcon.prototype = {
_iconClick: function(event)
{
event.consume(true);
- if (this._stylesPopoverHelper.isShowing()) {
- this._stylesPopoverHelper.hide(true);
+ if (this._swatchPopoverHelper.isShowing()) {
+ this._swatchPopoverHelper.hide(true);
return;
}
@@ -193,7 +183,10 @@ WebInspector.BezierPopoverIcon.prototype = {
var geometry = WebInspector.Geometry.CubicBezier.parse(this._bezierValueElement.textContent);
this._bezierEditor.setBezier(geometry);
this._bezierEditor.addEventListener(WebInspector.BezierEditor.Events.BezierChanged, this._boundBezierChanged);
- this._stylesPopoverHelper.show(this._bezierEditor, this._iconElement, this._onPopoverHidden.bind(this));
+ this._swatchPopoverHelper.show(this._bezierEditor, this._iconElement, this._onPopoverHidden.bind(this));
+ this._scrollerElement = this._iconElement.enclosingNodeOrSelfWithClass("style-panes-wrapper");
+ if (this._scrollerElement)
+ this._scrollerElement.addEventListener("scroll", this._boundOnScroll, false);
this._originalPropertyText = this._treeElement.property.propertyText;
this._treeElement.parentPane().setEditingStyle(true);
@@ -212,10 +205,21 @@ WebInspector.BezierPopoverIcon.prototype = {
},
/**
+ * @param {!Event} event
+ */
+ _onScroll: function(event)
+ {
+ this._swatchPopoverHelper.reposition();
+ },
+
+ /**
* @param {boolean} commitEdit
*/
_onPopoverHidden: function(commitEdit)
{
+ if (this._scrollerElement)
+ this._scrollerElement.removeEventListener("scroll", this._boundOnScroll, false);
+
this._bezierEditor.removeEventListener(WebInspector.BezierEditor.Events.BezierChanged, this._boundBezierChanged);
delete this._bezierEditor;
@@ -229,14 +233,14 @@ WebInspector.BezierPopoverIcon.prototype = {
/**
* @constructor
* @param {!WebInspector.StylePropertyTreeElement} treeElement
- * @param {!WebInspector.StylesPopoverHelper} stylesPopoverHelper
+ * @param {!WebInspector.SwatchPopoverHelper} swatchPopoverHelper
* @param {string} colorText
*/
-WebInspector.ColorSwatchPopoverIcon = function(treeElement, stylesPopoverHelper, colorText)
+WebInspector.ColorSwatchPopoverIcon = function(treeElement, swatchPopoverHelper, colorText)
{
this._treeElement = treeElement;
this._treeElement[WebInspector.ColorSwatchPopoverIcon._treeElementSymbol] = this;
- this._stylesPopoverHelper = stylesPopoverHelper;
+ this._swatchPopoverHelper = swatchPopoverHelper;
this._swatch = WebInspector.ColorSwatch.create();
this._swatch.setColorText(colorText);
@@ -247,6 +251,7 @@ WebInspector.ColorSwatchPopoverIcon = function(treeElement, stylesPopoverHelper,
this._contrastColor = null;
this._boundSpectrumChanged = this._spectrumChanged.bind(this);
+ this._boundOnScroll = this._onScroll.bind(this);
}
WebInspector.ColorSwatchPopoverIcon._treeElementSymbol = Symbol("WebInspector.ColorSwatchPopoverIcon._treeElementSymbol");
@@ -290,8 +295,8 @@ WebInspector.ColorSwatchPopoverIcon.prototype = {
showPopover: function()
{
- if (this._stylesPopoverHelper.isShowing()) {
- this._stylesPopoverHelper.hide(true);
+ if (this._swatchPopoverHelper.isShowing()) {
+ this._swatchPopoverHelper.hide(true);
return;
}
@@ -306,7 +311,10 @@ WebInspector.ColorSwatchPopoverIcon.prototype = {
this._spectrum.addEventListener(WebInspector.Spectrum.Events.SizeChanged, this._spectrumResized, this);
this._spectrum.addEventListener(WebInspector.Spectrum.Events.ColorChanged, this._boundSpectrumChanged);
- this._stylesPopoverHelper.show(this._spectrum, this._swatch.iconElement(), this._onPopoverHidden.bind(this));
+ this._swatchPopoverHelper.show(this._spectrum, this._swatch.iconElement(), this._onPopoverHidden.bind(this));
+ this._scrollerElement = this._swatch.enclosingNodeOrSelfWithClass("style-panes-wrapper");
+ if (this._scrollerElement)
+ this._scrollerElement.addEventListener("scroll", this._boundOnScroll, false);
this._originalPropertyText = this._treeElement.property.propertyText;
this._treeElement.parentPane().setEditingStyle(true);
@@ -320,7 +328,7 @@ WebInspector.ColorSwatchPopoverIcon.prototype = {
*/
_spectrumResized: function(event)
{
- this._stylesPopoverHelper.reposition();
+ this._swatchPopoverHelper.reposition();
},
/**
@@ -334,10 +342,21 @@ WebInspector.ColorSwatchPopoverIcon.prototype = {
},
/**
+ * @param {!Event} event
+ */
+ _onScroll: function(event)
+ {
+ this._swatchPopoverHelper.reposition();
+ },
+
+ /**
* @param {boolean} commitEdit
*/
_onPopoverHidden: function(commitEdit)
{
+ if (this._scrollerElement)
+ this._scrollerElement.removeEventListener("scroll", this._boundOnScroll, false);
+
this._spectrum.removeEventListener(WebInspector.Spectrum.Events.ColorChanged, this._boundSpectrumChanged);
delete this._spectrum;
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698