Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2161733002: DevTools: Move WebInspector.SwatchPopoverHelper into new file ui/SwatchPopoverHelper.js (Closed)

Created:
4 years, 5 months ago by flandy
Modified:
4 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@rename1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Move WebInspector.SwatchPopoverHelper into new file ui/SwatchPopoverHelper.js Also, rename elements/StylesPopoverHelper.js to ColorSwatchPopoverIcon.js. This will allow the SwatchPopoverHelper to be re-used in Sources. BUG=none R=lushnikov Committed: https://crrev.com/024a40e25b6c9ae2ed0c5851ac5b6ca4ddd11649 Cr-Commit-Position: refs/heads/master@{#406208}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -491 lines) Patch
M third_party/WebKit/Source/devtools/devtools.gypi View 3 chunks +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js View 1 chunk +0 lines, -120 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/elements/StylesPopoverHelper.js View 1 chunk +0 lines, -368 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/module.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js View 1 chunk +123 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/module.json View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
flandy
CL 2 for extracting StylesPopoverHelper. Please take a look.
4 years, 5 months ago (2016-07-18 19:26:16 UTC) #1
lushnikov
lgtm https://codereview.chromium.org/2161733002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/module.json File third_party/WebKit/Source/devtools/front_end/elements/module.json (right): https://codereview.chromium.org/2161733002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/module.json#newcode167 third_party/WebKit/Source/devtools/front_end/elements/module.json:167: "ColorSwatchPopoverIcon.js", nit: let's keep this before BezierEditor (BezierPopoverIcon ...
4 years, 5 months ago (2016-07-18 23:00:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161733002/20001
4 years, 5 months ago (2016-07-18 23:33:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 03:55:36 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 03:55:40 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 03:57:38 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/024a40e25b6c9ae2ed0c5851ac5b6ca4ddd11649
Cr-Commit-Position: refs/heads/master@{#406208}

Powered by Google App Engine
This is Rietveld 408576698