blimp/engine/testing/Dockerfile - Issue 2154873002: Update ADD handling in Dockerfiles and test bundle creation

Unified Diff: blimp/engine/testing/Dockerfile

Issue 2154873002: Update ADD handling in Dockerfiles and test bundle creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename varables to py style guide. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/engine/testing/Dockerfile

diff --git a/blimp/engine/testing/Dockerfile b/blimp/engine/testing/Dockerfile

index 71c87fc8f93373d464d83d126631c2e39d2a78da..b50e979b5701b7add9321e42f718e0256e437b80 100644

--- a/blimp/engine/testing/Dockerfile

+++ b/blimp/engine/testing/Dockerfile

@@ -4,15 +4,13 @@

# Engine itself.

FROM base:latest

maniscalco 2016/07/18 16:01:04 Can you please attached an example of the tar file

Jess 2016/07/18 17:19:14 Sure. Directories with large expansions are summar

-RUN mkdir -p /out/test/

+RUN mkdir -p /blimp/out/test

maniscalco 2016/07/18 16:01:04 I realize we need to mkdir /blimp, but do we need

Jess 2016/07/18 17:19:14 Done.

-# The glob below expands to all files, but does not add directories

-# recursively.

-# Test binaries assume src directory is 2 levels down. While this behavior can

-# be changed with flags, the directory structure is set up to minimize

-# potential problems with initial integration.

-ADD * /out/test/

+RUN useradd -ms /bin/bash blimp_user

-RUN chown -R blimp_user /out/test/

+# Copy complete docker root dir into /blimp directory.

maniscalco 2016/07/18 16:01:04 Can you change this to explain why we're copying t

Jess 2016/07/18 17:19:14 Done.

+ADD . /blimp/

+RUN chown -R blimp_user /blimp

USER blimp_user

« blimp/engine/Dockerfile ('K') | « blimp/engine/Dockerfile ('k') | blimp/tools/create-bundle.py » ('j') | blimp/tools/create-bundle.py » ('J')