blimp/engine/testing/Dockerfile - Issue 2154873002: Update ADD handling in Dockerfiles and test bundle creation

Side by Side Diff: blimp/engine/testing/Dockerfile

Issue 2154873002: Update ADD handling in Dockerfiles and test bundle creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename varables to py style guide. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # This Dockerfile is used to build a filesystem environment containing	1 # This Dockerfile is used to build a filesystem environment containing

2 # binaries and required files for Blimp Engine test and tests for dependencies	2 # binaries and required files for Blimp Engine test and tests for dependencies

3 # of Blimp Engine. It is built on the same base image that is used to run the	3 # of Blimp Engine. It is built on the same base image that is used to run the

4 # Engine itself.	4 # Engine itself.

5 FROM base:latest	5 FROM base:latest
	maniscalco 2016/07/18 16:01:04 Can you please attached an example of the tar file Can you please attached an example of the tar file contents (i.e. tar tzf output)? Doesn't have to be the full listing, just enough for someone to review the change. Can you do this for both the engine and the test bundles? Jess 2016/07/18 17:19:14 Sure. Directories with large expansions are summar Show quoted text On 2016/07/18 16:01:04, maniscalco wrote: > Can you please attached an example of the tar file contents (i.e. tar tzf > output)? Doesn't have to be the full listing, just enough for someone to review > the change. Can you do this for both the engine and the test bundles? Sure. Directories with large expansions are summaryized with ... at the base of the expansion. Note that the build directory prefix for the testing bundle ("out-linux/Debug" here) is specific to the build. $ tar -tzf out-linux/Debug/blimp_engine_bundle.tar.gz blimp_engine_app blimp_engine.pak chrome_sandbox gen/third_party/blimp_fonts/... icudtl.dat natives_blob.bin libui_library.so Dockerfile Dockerfile.base start_engine.sh $tar -tzf out-linux/Debug/blimp_engine_env_tests_bundle.tar.gz ut-linux/Debug/blimp_unittests out-linux/Debug/icudtl.dat out-linux/Debug/natives_blob.bin out-linux/Debug/libui_library.so blimp/client/session/test_selfsigned_cert.pem blimp/test/data/test_client_token net/data/... out-linux/Debug/base_unittests base/test/data/... out-linux/Debug/libmalloc_wrapper.so Dockerfile Dockerfile.base
6	6

7 RUN mkdir -p /out/test/	7 RUN mkdir -p /blimp/out/test
	maniscalco 2016/07/18 16:01:04 I realize we need to mkdir /blimp, but do we need I realize we need to mkdir /blimp, but do we need to make out/test as well? Won't those be created automatically when we ADD further down? Jess 2016/07/18 17:19:14 Done. Show quoted text On 2016/07/18 16:01:04, maniscalco wrote: > I realize we need to mkdir /blimp, but do we need to make out/test as well? > Won't those be created automatically when we ADD further down? Done.
8	8

9 # The glob below expands to all files, but does not add directories	9 RUN useradd -ms /bin/bash blimp_user

10 # recursively.

11 # Test binaries assume src directory is 2 levels down. While this behavior can

12 # be changed with flags, the directory structure is set up to minimize

13 # potential problems with initial integration.

14 ADD * /out/test/

15	10

16 RUN chown -R blimp_user /out/test/	11 # Copy complete docker root dir into /blimp directory.
	maniscalco 2016/07/18 16:01:04 Can you change this to explain why we're copying t Can you change this to explain why we're copying things they way we are? For example: # Put all the blimp related files in /blimp so they are kept separate from the OS files. Some of these executable make use of data using paths relative to the executable's path so add "." to preserve input directory structure. Jess 2016/07/18 17:19:14 Done. Show quoted text On 2016/07/18 16:01:04, maniscalco wrote: > Can you change this to explain why we're copying things they way we are? For > example: > > # Put all the blimp related files in /blimp so they are kept separate from the > OS files. Some of these executable make use of data using paths relative to the > executable's path so add "." to preserve input directory structure. Done.
	12 ADD . /blimp/

	13

	14 RUN chown -R blimp_user /blimp

17	15

18 USER blimp_user	16 USER blimp_user

OLD	NEW

« blimp/engine/Dockerfile ('K') | « blimp/engine/Dockerfile ('k') | blimp/tools/create-bundle.py » ('j') | blimp/tools/create-bundle.py » ('J')