blimp/engine/Dockerfile - Issue 2154873002: Update ADD handling in Dockerfiles and test bundle creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/engine/Dockerfile

Issue 2154873002: Update ADD handling in Dockerfiles and test bundle creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename varables to py style guide. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/engine/Dockerfile

diff --git a/blimp/engine/Dockerfile b/blimp/engine/Dockerfile

index 12b4b61894afe2372d701bfe99e715201485fdd0..e4ed62cae600e1119c261891b5c5a4e33e9c8f12 100644

--- a/blimp/engine/Dockerfile

+++ b/blimp/engine/Dockerfile

@@ -4,8 +4,8 @@ RUN mkdir /engine

RUN useradd -ms /bin/bash blimp_user

-# The glob below expands to all files, but does not add directories

-# recursively.

+# The glob below expands to all files in the working directory and the

+# contents of any subdirectory there.

maniscalco 2016/07/18 16:01:04 nit: I'd probably just skip this kind of comment a

Jess 2016/07/18 17:19:14 Done.

ADD * /engine/

ADD gen/third_party/blimp_fonts /engine/fonts

RUN mv /engine/chrome_sandbox /engine/chrome-sandbox

« no previous file with comments | « blimp/BUILD.gn ('k') | blimp/engine/testing/Dockerfile » ('j') | blimp/engine/testing/Dockerfile » ('J')