fpdfsdk/fpdfxfa/include/fpdfxfa_app.h - Issue 2154843002: Clean up singleton implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfxfa/include/fpdfxfa_app.h

Issue 2154843002: Clean up singleton implementation (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfxfa/include/fpdfxfa_app.h

diff --git a/fpdfsdk/fpdfxfa/include/fpdfxfa_app.h b/fpdfsdk/fpdfxfa/include/fpdfxfa_app.h

index 993d4b42543f06de5eb93a9f3badf28e5362f2bb..579faecf55ec89121907910da7130aa5cb766c2e 100644

--- a/fpdfsdk/fpdfxfa/include/fpdfxfa_app.h

+++ b/fpdfsdk/fpdfxfa/include/fpdfxfa_app.h

@@ -78,7 +78,7 @@ class CPDFXFA_App : public IXFA_AppProvider {

CFX_ArrayTemplate<CPDFDoc_Environment*> m_pEnvList;

protected:

- static CPDFXFA_App* g_pApp;

+ static CPDFXFA_App* m_pApp;

Lei Zhang 2016/07/16 01:23:03 Only used in fpdfsdk/fpdfxfa/fpdfxfa_app.cpp, and

Wei Li 2016/07/18 19:07:07 Not much difference, let's keep the implementation

FX_BOOL m_bJavaScriptInitialized;

CXFA_FFApp* m_pXFAApp;