fpdfsdk/fpdfxfa/include/fpdfxfa_app.h - Issue 2154843002: Clean up singleton implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: fpdfsdk/fpdfxfa/include/fpdfxfa_app.h

Issue 2154843002: Clean up singleton implementation (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« core/fxge/include/fx_ge.h ('K') | « fpdfsdk/fpdfxfa/fpdfxfa_app.cpp ('k') | fpdfsdk/javascript/JS_GlobalData.h » ('j') | fpdfsdk/javascript/JS_GlobalData.h » ('J')

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #ifndef FPDFSDK_FPDFXFA_INCLUDE_FPDFXFA_APP_H_	7 #ifndef FPDFSDK_FPDFXFA_INCLUDE_FPDFXFA_APP_H_

8 #define FPDFSDK_FPDFXFA_INCLUDE_FPDFXFA_APP_H_	8 #define FPDFSDK_FPDFXFA_INCLUDE_FPDFXFA_APP_H_

9	9

10 #include "xfa/fxfa/include/fxfa.h"	10 #include "xfa/fxfa/include/fxfa.h"

(...skipping 60 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
71 FX_BOOL PutRequestURL(const CFX_WideString& wsURL,	71 FX_BOOL PutRequestURL(const CFX_WideString& wsURL,

72 const CFX_WideString& wsData,	72 const CFX_WideString& wsData,

73 const CFX_WideString& wsEncode) override;	73 const CFX_WideString& wsEncode) override;

74	74

75 void LoadString(int32_t iStringID, CFX_WideString& wsString) override;	75 void LoadString(int32_t iStringID, CFX_WideString& wsString) override;

76 IFWL_AdapterTimerMgr* GetTimerMgr() override;	76 IFWL_AdapterTimerMgr* GetTimerMgr() override;

77	77

78 CFX_ArrayTemplate<CPDFDoc_Environment*> m_pEnvList;	78 CFX_ArrayTemplate<CPDFDoc_Environment*> m_pEnvList;

79	79

80 protected:	80 protected:

81 static CPDFXFA_App* g_pApp;	81 static CPDFXFA_App* m_pApp;
	Lei Zhang 2016/07/16 01:23:03 Only used in fpdfsdk/fpdfxfa/fpdfxfa_app.cpp, and Only used in fpdfsdk/fpdfxfa/fpdfxfa_app.cpp, and fpdfsdk/fpdfxfa/fpdfxfa_app.cpp does not contain any other classes - put it in there instead? Wei Li 2016/07/18 19:07:07 Not much difference, let's keep the implementation Show quoted text On 2016/07/16 01:23:03, Lei Zhang wrote: > Only used in fpdfsdk/fpdfxfa/fpdfxfa_app.cpp, and > fpdfsdk/fpdfxfa/fpdfxfa_app.cpp does not contain any other classes - put it in > there instead? Not much difference, let's keep the implementation uniform?
82	82

83 FX_BOOL m_bJavaScriptInitialized;	83 FX_BOOL m_bJavaScriptInitialized;

84 CXFA_FFApp* m_pXFAApp;	84 CXFA_FFApp* m_pXFAApp;

85 v8::Isolate* m_pIsolate;	85 v8::Isolate* m_pIsolate;

86 IFXJS_Runtime* m_pJSRuntime;	86 IFXJS_Runtime* m_pJSRuntime;

87 CFX_WideString m_csAppType;	87 CFX_WideString m_csAppType;

88 };	88 };

89	89

90 #endif // FPDFSDK_FPDFXFA_INCLUDE_FPDFXFA_APP_H_	90 #endif // FPDFSDK_FPDFXFA_INCLUDE_FPDFXFA_APP_H_

OLD	NEW