fpdfsdk/javascript/JS_GlobalData.h - Issue 2154843002: Clean up singleton implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/JS_GlobalData.h

Issue 2154843002: Clean up singleton implementation (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/javascript/JS_GlobalData.h

diff --git a/fpdfsdk/javascript/JS_GlobalData.h b/fpdfsdk/javascript/JS_GlobalData.h

index 8273c0838c0371e7923069638c2d81afa23f6786..5936b7c9962a519e013cb74f4d725728103efeaa 100644

--- a/fpdfsdk/javascript/JS_GlobalData.h

+++ b/fpdfsdk/javascript/JS_GlobalData.h

@@ -84,7 +84,7 @@ class CJS_GlobalData {

using const_iterator =

std::vector<std::unique_ptr<CJS_GlobalData_Element>>::const_iterator;

- static CJS_GlobalData* g_Instance;

+ static CJS_GlobalData* m_pInstance;

Lei Zhang 2016/07/16 01:23:03 s_ for static?

Wei Li 2016/07/18 19:07:07 Done.

CJS_GlobalData();

~CJS_GlobalData();