Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2154623002: [DevTools] Make most fields of ExceptionDetails non-optional. (Closed)

Created:
4 years, 5 months ago by dgozman
Modified:
4 years, 5 months ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Make most fields of ExceptionDetails non-optional. Renamed stack to stackTrace. BUG=none Committed: https://crrev.com/c4f79076639cb6df2074158fdfcbb0fb9ce8cb03 Cr-Commit-Position: refs/heads/master@{#405780}

Patch Set 1 #

Messages

Total messages: 13 (5 generated)
dgozman
Take a look please!
4 years, 5 months ago (2016-07-15 02:11:31 UTC) #2
kozy
lgtm
4 years, 5 months ago (2016-07-15 02:14:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154623002/1
4 years, 5 months ago (2016-07-15 14:30:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/104799)
4 years, 5 months ago (2016-07-15 16:04:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154623002/1
4 years, 5 months ago (2016-07-15 16:43:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 17:19:34 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 17:19:42 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 17:22:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4f79076639cb6df2074158fdfcbb0fb9ce8cb03
Cr-Commit-Position: refs/heads/master@{#405780}

Powered by Google App Engine
This is Rietveld 408576698