Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

Issue 2154623002: [DevTools] Make most fields of ExceptionDetails non-optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
index d6a02283c505438b6366882c83bbb88e33e24e60..29bc2bd226547e7f8ef1286e23a56b67e6f0d45e 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp
@@ -297,16 +297,16 @@ void V8ConsoleMessage::reportToFrontend(protocol::Runtime::Frontend* frontend, V
{
if (m_origin == V8MessageOrigin::kException) {
// TODO(dgozman): unify with InjectedScript::createExceptionDetails.
- std::unique_ptr<protocol::Runtime::ExceptionDetails> details = protocol::Runtime::ExceptionDetails::create().setText(m_message).build();
- details->setUrl(m_url);
- if (m_lineNumber)
- details->setLineNumber(static_cast<int>(m_lineNumber) - 1);
- if (m_columnNumber)
- details->setColumnNumber(static_cast<int>(m_columnNumber) - 1);
- if (m_scriptId)
- details->setScriptId(String16::fromInteger(m_scriptId));
+ std::unique_ptr<protocol::Runtime::ExceptionDetails> details = protocol::Runtime::ExceptionDetails::create()
+ .setText(m_message)
+ .setLineNumber(m_lineNumber ? m_lineNumber - 1 : 0)
+ .setColumnNumber(m_columnNumber ? m_columnNumber - 1 : 0)
+ .setScriptId(m_scriptId ? String16::fromInteger(m_scriptId) : String16())
+ .build();
+ if (!m_url.isEmpty())
+ details->setUrl(m_url);
if (m_stackTrace)
- details->setStack(m_stackTrace->buildInspectorObject());
+ details->setStackTrace(m_stackTrace->buildInspectorObject());
std::unique_ptr<protocol::Runtime::RemoteObject> exception = wrapException(session, generatePreview);

Powered by Google App Engine
This is Rietveld 408576698