third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js - Issue 2154623002: [DevTools] Make most fields of ExceptionDetails non-optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

Issue 2154623002: [DevTools] Make most fields of ExceptionDetails non-optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js ('k') | third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

index bf764a52096169df731f5bea8c61e9ae39a9b900..260c94c3fe52ab0791c91ac54700c449fd8b2ae8 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

@@ -371,11 +371,11 @@ WebInspector.RuntimeDispatcher.prototype = {

details.text,

undefined,

details.url,

- typeof details.lineNumber === "undefined" ? undefined : details.lineNumber + 1,

- typeof details.columnNumber === "undefined" ? undefined : details.columnNumber + 1,

+ details.lineNumber + 1,

+ details.columnNumber + 1,

undefined,

exception ? ["Uncaught (in promise)", exception] : undefined,

- details.stack,

+ details.stackTrace,

timestamp,

executionContextId,

details.scriptId);