Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 2154593003: [css-grid] Fix indefinite height detection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix fast/table/003.html test Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h
index 631a6a150e246bb2782e63120f5c84cdc5600211..e7e89f29344c18a04bcf6a8b4fb7e85029a0fe62 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h
@@ -201,7 +201,6 @@ public:
// Use this with caution! No type checking is done!
LayoutBox* firstChildBox() const;
- LayoutBox* firstInFlowChildBox() const;
LayoutBox* lastChildBox() const;
int pixelSnappedWidth() const { return m_frameRect.pixelSnappedWidth(); }
@@ -742,6 +741,7 @@ public:
virtual LayoutUnit computeReplacedLogicalHeight(LayoutUnit estimatedUsedWidth = LayoutUnit()) const;
bool percentageLogicalHeightIsResolvable() const;
+ static LayoutUnit availableLogicalHeightForPercentageComputation(const LayoutBlock*, bool skippedAutoHeightContainingBlock, bool scrollsOverflowY);
svillar 2016/07/18 08:43:30 If the first parameter is never null then it shoul
Manuel Rego 2016/07/19 13:12:32 Done.
LayoutUnit computePercentageLogicalHeight(const Length& height) const;
// Block flows subclass availableWidth/Height to handle multi column layout (shrinking the width/height available to children when laying out.)
@@ -1183,14 +1183,6 @@ inline LayoutBox* LayoutBox::firstChildBox() const
return toLayoutBox(slowFirstChild());
}
-inline LayoutBox* LayoutBox::firstInFlowChildBox() const
-{
- LayoutBox* child = firstChildBox();
- while (child && child->isOutOfFlowPositioned())
- child = child->nextSiblingBox();
- return child;
-}
-
inline LayoutBox* LayoutBox::lastChildBox() const
{
return toLayoutBox(slowLastChild());

Powered by Google App Engine
This is Rietveld 408576698