[css-grid] Fix indefinite height detection

third_party/WebKit/Source/core/layout/LayoutBox.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 183 matching lines @@
     explicit LayoutBox(ContainerNode*);
 
     PaintLayerType layerTypeRequired() const override;
 
     bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect) const override;
 
     virtual bool backgroundShouldAlwaysBeClipped() const { return false; }
 
     // Use this with caution! No type checking is done!
     LayoutBox* firstChildBox() const;
-    LayoutBox* firstInFlowChildBox() const;
     LayoutBox* lastChildBox() const;
 
     int pixelSnappedWidth() const { return m_frameRect.pixelSnappedWidth(); }
     int pixelSnappedHeight() const { return m_frameRect.pixelSnappedHeight(); }
 
     void setX(LayoutUnit x)
     {
         if (x == m_frameRect.x())
             return;
         m_frameRect.setX(x);
@@ skipping 520 matching lines @@
     LayoutUnit computeContentAndScrollbarLogicalHeightUsing(SizeType, const Length& height, LayoutUnit intrinsicContentHeight) const;
     LayoutUnit computeReplacedLogicalWidthUsing(SizeType, const Length& width) const;
     LayoutUnit computeReplacedLogicalWidthRespectingMinMaxWidth(LayoutUnit logicalWidth, ShouldComputePreferred  = ComputeActual) const;
     LayoutUnit computeReplacedLogicalHeightUsing(SizeType, const Length& height) const;
     LayoutUnit computeReplacedLogicalHeightRespectingMinMaxHeight(LayoutUnit logicalHeight) const;
 
     virtual LayoutUnit computeReplacedLogicalWidth(ShouldComputePreferred  = ComputeActual) const;
     virtual LayoutUnit computeReplacedLogicalHeight(LayoutUnit estimatedUsedWidth = LayoutUnit()) const;
 
     bool percentageLogicalHeightIsResolvable() const;
+    static LayoutUnit availableLogicalHeightForPercentageComputation(const LayoutBlock*, bool skippedAutoHeightContainingBlock, bool scrollsOverflowY);

[svillar, 2016/07/18 08:43:30]

If the first parameter is never null then it should be a reference instead

Same comment about bools.

[Manuel Rego, 2016/07/19 13:12:32]

Done.

     LayoutUnit computePercentageLogicalHeight(const Length& height) const;
 
     // Block flows subclass availableWidth/Height to handle multi column layout (shrinking the width/height available to children when laying out.)
     LayoutUnit availableLogicalWidth() const { return contentLogicalWidth(); }
     LayoutUnit availableLogicalHeight(AvailableLogicalHeightType) const;
     LayoutUnit availableLogicalHeightUsing(const Length&, AvailableLogicalHeightType) const;
 
     // There are a few cases where we need to refer specifically to the available physical width and available physical height.
     // Relative positioning is one of those cases, since left/top offsets are physical.
     LayoutUnit availableWidth() const { return style()->isHorizontalWritingMode() ? availableLogicalWidth() : availableLogicalHeight(IncludeMarginBorderPadding); }
@@ skipping 421 matching lines @@
 inline LayoutBox* LayoutBox::parentBox() const
 {
     return toLayoutBox(parent());
 }
 
 inline LayoutBox* LayoutBox::firstChildBox() const
 {
     return toLayoutBox(slowFirstChild());
 }
 
-inline LayoutBox* LayoutBox::firstInFlowChildBox() const
-{
-    LayoutBox* child = firstChildBox();
-    while (child && child->isOutOfFlowPositioned())
-        child = child->nextSiblingBox();
-    return child;
-}
-
 inline LayoutBox* LayoutBox::lastChildBox() const
 {
     return toLayoutBox(slowLastChild());
 }
 
 inline LayoutBox* LayoutBox::previousSiblingMultiColumnBox() const
 {
     ASSERT(isLayoutMultiColumnSpannerPlaceholder() || isLayoutMultiColumnSet());
     LayoutBox* previousBox = previousSiblingBox();
     if (previousBox->isLayoutFlowThread())
@@ skipping 28 matching lines @@
         || breakValue == BreakLeft
         || breakValue == BreakPage
         || breakValue == BreakRecto
         || breakValue == BreakRight
         || breakValue == BreakVerso;
 }
 
 } // namespace blink
 
 #endif // LayoutBox_h