third_party/WebKit/Source/core/layout/LayoutBlock.cpp - Issue 2154593003: [css-grid] Fix indefinite height detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2154593003: [css-grid] Fix indefinite height detection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix fast/table/003.html test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

index 04c701c370f4fcc0f87c82d3f54ac3fae6a5d6d9..1d0f05a7e0afb45b434c4c2e577061c3c677d744 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

@@ -1872,4 +1872,9 @@ void LayoutBlock::checkPositionedObjectsNeedLayout()

#endif

+bool LayoutBlock::hasDefiniteLogicalHeight() const

+ return LayoutBox::availableLogicalHeightForPercentageComputation(this, false, scrollsOverflowY()) != LayoutUnit(-1);

svillar 2016/07/18 08:43:30 This is one of the reasons why bools are normally

} // namespace blink