third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-grid-container-percentage-rows-expected.html - Issue 2154593003: [css-grid] Fix indefinite height detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-grid-container-percentage-rows-expected.html

Issue 2154593003: [css-grid] Fix indefinite height detection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check skipContainingBlockForPercentHeightCalculation() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-grid-container-percentage-rows.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-grid-container-percentage-rows-expected.html

diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-item-grid-container-percentage-rows-expected.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-grid-container-percentage-rows-expected.html

similarity index 86%

copy from third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-item-grid-container-percentage-rows-expected.html

copy to third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-grid-container-percentage-rows-expected.html

index 381c3ad6c3d3434b44ec840128a3b7db446de618..563ca031d371d91eaa98213c0f110599fb652968 100644

--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-item-grid-container-percentage-rows-expected.html

+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-grid-container-percentage-rows-expected.html

@@ -20,7 +20,7 @@

</style>

-<p>This test checks that percentage rows are properly resolved for a grid container that is a flex item with a definite height.</p>

+<p>This test checks that percentage rows are properly resolved for a grid container that is a stretched grid item.</p>

<p>Test passes if you see a 200x200 box with top half cyan and bottom half magenta.</p>