Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html

Issue 2154593003: [css-grid] Fix indefinite height detection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check skipContainingBlockForPercentHeightCalculation() Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html
index 731dd5f1529109a18fa62aaf94ebbb26d5b28390..db2f245065c34ecacad904ff9cbfbf945e8681d1 100644
--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html
@@ -30,8 +30,8 @@ body {
<div class="grid itemsStart contentStart fit-content" data-expected-width="110" data-expected-height="260">
<div class="firstRowFirstColumn verticalLR" data-offset-x="0" data-offset-y="0" data-expected-width="10" data-expected-height="50">X X X</div>
<div class="firstRowSecondColumn verticalLR" data-offset-x="100" data-offset-y="0" data-expected-width="10" data-expected-height="110">X X X X X X</div>
- <div class="secondRowFirstColumn verticalLR" data-offset-x="0" data-offset-y="130" data-expected-width="10" data-expected-height="110">X X X X X X</div>
- <div class="secondRowSecondColumn verticalLR" data-offset-x="100" data-offset-y="130" data-expected-width="20" data-expected-height="150">X X X X X X X X X X X X</div>
+ <div class="secondRowFirstColumn verticalLR" data-offset-x="0" data-offset-y="110" data-expected-width="10" data-expected-height="110">X X X X X X</div>
+ <div class="secondRowSecondColumn verticalLR" data-offset-x="100" data-offset-y="110" data-expected-width="20" data-expected-height="150">X X X X X X X X X X X X</div>
</div>
</div>
@@ -40,8 +40,8 @@ body {
<div class="grid itemsStart contentStart fit-content" data-expected-width="110" data-expected-height="260">
<div class="firstRowFirstColumn verticalRL" data-offset-x="0" data-offset-y="0" data-expected-width="10" data-expected-height="50">X X X</div>
<div class="firstRowSecondColumn verticalRL" data-offset-x="100" data-offset-y="0" data-expected-width="10" data-expected-height="110">X X X X X X</div>
- <div class="secondRowFirstColumn verticalRL" data-offset-x="0" data-offset-y="130" data-expected-width="10" data-expected-height="110">X X X X X X</div>
- <div class="secondRowSecondColumn verticalRL" data-offset-x="100" data-offset-y="130" data-expected-width="20" data-expected-height="150">X X X X X X X X X X X X</div>
+ <div class="secondRowFirstColumn verticalRL" data-offset-x="0" data-offset-y="110" data-expected-width="10" data-expected-height="110">X X X X X X</div>
+ <div class="secondRowSecondColumn verticalRL" data-offset-x="100" data-offset-y="110" data-expected-width="20" data-expected-height="150">X X X X X X X X X X X X</div>
</div>
</div>
@@ -50,8 +50,8 @@ body {
<div class="grid itemsStart contentStart verticalLR fit-content" data-expected-width="260" data-expected-height="120">
<div class="firstRowFirstColumn horizontalTB" data-offset-x="0" data-offset-y="0" data-expected-width="50" data-expected-height="10">X X X</div>
<div class="firstRowSecondColumn horizontalTB" data-offset-x="0" data-offset-y="100" data-expected-width="110" data-expected-height="10">X X X X X X</div>
- <div class="secondRowFirstColumn horizontalTB" data-offset-x="130" data-offset-y="0" data-expected-width="110" data-expected-height="10">X X X X X X</div>
- <div class="secondRowSecondColumn horizontalTB" data-offset-x="130" data-offset-y="100" data-expected-width="150" data-expected-height="20">X X X X X X X X X X X X</div>
+ <div class="secondRowFirstColumn horizontalTB" data-offset-x="110" data-offset-y="0" data-expected-width="110" data-expected-height="10">X X X X X X</div>
+ <div class="secondRowSecondColumn horizontalTB" data-offset-x="110" data-offset-y="100" data-expected-width="150" data-expected-height="20">X X X X X X X X X X X X</div>
</div>
</div>
@@ -60,8 +60,8 @@ body {
<div class="grid itemsStart contentStart verticalRL fit-content" data-expected-width="260" data-expected-height="120">
<div class="firstRowFirstColumn horizontalTB" data-offset-x="210" data-offset-y="0" data-expected-width="50" data-expected-height="10">X X X</div>
<div class="firstRowSecondColumn horizontalTB" data-offset-x="150" data-offset-y="100" data-expected-width="110" data-expected-height="10">X X X X X X</div>
- <div class="secondRowFirstColumn horizontalTB" data-offset-x="20" data-offset-y="0" data-expected-width="110" data-expected-height="10">X X X X X X</div>
- <div class="secondRowSecondColumn horizontalTB" data-offset-x="-20" data-offset-y="100" data-expected-width="150" data-expected-height="20">X X X X X X X X X X X X</div>
+ <div class="secondRowFirstColumn horizontalTB" data-offset-x="40" data-offset-y="0" data-expected-width="110" data-expected-height="10">X X X X X X</div>
+ <div class="secondRowSecondColumn horizontalTB" data-offset-x="0" data-offset-y="100" data-expected-width="150" data-expected-height="20">X X X X X X X X X X X X</div>
</div>
</div>
</body>

Powered by Google App Engine
This is Rietveld 408576698