third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-grid-container-percentage-rows.html - Issue 2154593003: [css-grid] Fix indefinite height detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-grid-container-percentage-rows.html

Issue 2154593003: [css-grid] Fix indefinite height detection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check skipContainingBlockForPercentHeightCalculation() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-container-percentage-rows.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-grid-container-percentage-rows-expected.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-grid-container-percentage-rows.html

diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-item-grid-container-percentage-rows.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-grid-container-percentage-rows.html

similarity index 53%

copy from third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-item-grid-container-percentage-rows.html

copy to third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-grid-container-percentage-rows.html

index 906913d8cbf3c842b56671c8f130eff8eacadfbe..b77d9cc8a3dc19265a298097ad1bb9aca7525bf4 100644

--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-item-grid-container-percentage-rows.html

+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-grid-container-percentage-rows.html

@@ -1,36 +1,31 @@

<!DOCTYPE html>

-<link href="resources/grid.css" rel="stylesheet">

<style>

-.flex {

- display: flex;

- flex-direction: column;

+.outerGrid {

+ display: grid;

width: 200px;

height: 200px;

border: 5px solid;

-.flexitem {

- flex: 1;

+ grid: 200px / 200px;

background: magenta;

}

-.grid {

+.innerGrid {

display: grid;

grid: 50% / 1fr;

}

-.griditem {

+.gridItem {

background: cyan;

}

</style>

-<p>This test checks that percentage rows are properly resolved for a grid container that is a flex item with a definite height.</p>

+<p>This test checks that percentage rows are properly resolved for a grid container that is a stretched grid item.</p>

<p>Test passes if you see a 200x200 box with top half cyan and bottom half magenta.</p>

-<div class="flex">

- <div class="flexitem grid">

- <div class="griditem"></div>

+<div class="outerGrid">

+ <div class="innerGrid">

+ <div class="gridItem"></div>

</div>