Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2154343002: Added custom tags helper classes to the Observatory (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed typos in rendering_scheduler.dart #

Total comments: 3

Patch Set 3 : Fixed typos & Added comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -9 lines) Patch
M runtime/observatory/lib/elements.dart View 1 chunk +9 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/helpers/rendering_queue.dart View 1 2 1 chunk +72 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart View 1 1 chunk +108 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/helpers/tag.dart View 1 chunk +36 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/elements/shims/binding.dart View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
M runtime/observatory/web/index.html View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/web/main.dart View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cbernaschina
4 years, 5 months ago (2016-07-18 17:27:26 UTC) #2
Cutch
LGTM with some nits. Wait for Ryan's LGTM too. https://codereview.chromium.org/2154343002/diff/1/runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart File runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart (right): https://codereview.chromium.org/2154343002/diff/1/runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart#newcode15 runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart:15: ...
4 years, 5 months ago (2016-07-18 17:36:40 UTC) #3
cbernaschina
https://codereview.chromium.org/2154343002/diff/1/runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart File runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart (right): https://codereview.chromium.org/2154343002/diff/1/runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart#newcode15 runtime/observatory/lib/src/elements/helpers/rendering_scheduler.dart:15: /// Even related to a Renderable rendering phase. On ...
4 years, 5 months ago (2016-07-18 17:39:29 UTC) #4
rmacnak
lgtm https://codereview.chromium.org/2154343002/diff/20001/runtime/observatory/lib/src/elements/helpers/rendering_queue.dart File runtime/observatory/lib/src/elements/helpers/rendering_queue.dart (right): https://codereview.chromium.org/2154343002/diff/20001/runtime/observatory/lib/src/elements/helpers/rendering_queue.dart#newcode58 runtime/observatory/lib/src/elements/helpers/rendering_queue.dart:58: /// rendering cicle, otherwise it will be queued ...
4 years, 5 months ago (2016-07-18 17:58:19 UTC) #5
cbernaschina
4 years, 5 months ago (2016-07-18 18:08:41 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
3ebcc9fdd5163e542d50a088dfbb6b5c48b9383b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698