Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2154103002: [DevTools] Remove toProtocolValue from v8_inspector/public. (Closed)

Created:
4 years, 5 months ago by dgozman
Modified:
4 years, 5 months ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, haraken, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, cmumford, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, jsbell+idb_chromium.org, kinuko+watch, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove toProtocolValue from v8_inspector/public. It was only used in InspectorIndexedDBAgent, for no good reason. Replaced json with RemoteObject (as it was before: https://codereview.chromium.org/148253005). BUG=580337 Committed: https://crrev.com/7f3edbad81197b17b311c26b3d09f12cef804716 Cr-Commit-Position: refs/heads/master@{#406205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -61 lines) Patch
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 13 chunks +29 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.h View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
dgozman
Take a look please.
4 years, 5 months ago (2016-07-17 05:07:40 UTC) #3
dgozman
Andrey, mind taking a look?
4 years, 5 months ago (2016-07-18 17:02:26 UTC) #6
caseq
lgtm
4 years, 5 months ago (2016-07-18 17:12:57 UTC) #7
pfeldman
lgtm
4 years, 5 months ago (2016-07-18 18:22:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154103002/1
4 years, 5 months ago (2016-07-18 18:52:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/264482)
4 years, 5 months ago (2016-07-18 21:46:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154103002/1
4 years, 5 months ago (2016-07-18 21:57:32 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/264567)
4 years, 5 months ago (2016-07-19 00:48:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154103002/1
4 years, 5 months ago (2016-07-19 01:06:42 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 03:38:54 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 03:39:04 UTC) #21
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 03:41:09 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f3edbad81197b17b311c26b3d09f12cef804716
Cr-Commit-Position: refs/heads/master@{#406205}

Powered by Google App Engine
This is Rietveld 408576698