DevTools: remove references to modules/indexeddb from core/inspector

DevTools: remove references to modules/indexeddb from core/inspector

BUG=340221
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166697

[pfeldman, 2014-02-05 12:32:07]

https://codereview.chromium.org/148253005/diff/40001/Source/modules/indexeddb...
File Source/modules/indexeddb/IDBClient.cpp (right):

https://codereview.chromium.org/148253005/diff/40001/Source/modules/indexeddb...
Source/modules/indexeddb/IDBClient.cpp:29: OwnPtr<InspectorIndexedDBAgent>
inspectorAgent =
InspectorIndexedDBAgent::create(inspectorController.injectedScriptManager(),
inspectorController.pageAgent());
Inspector agents are private to inspector subsystem.

https://codereview.chromium.org/148253005/diff/40001/Source/modules/indexeddb...
File Source/modules/indexeddb/IDBClient.h (right):

https://codereview.chromium.org/148253005/diff/40001/Source/modules/indexeddb...
Source/modules/indexeddb/IDBClient.h:14: class IndexedDBClient : public
Supplement<Page> {
This is not really a client - you don't use it to communicate from Blink to
Chrome.

[Vladislav Kaznacheev, 2014-02-06 09:48:22]

PTAL

https://codereview.chromium.org/148253005/diff/40001/Source/modules/indexeddb...
File Source/modules/indexeddb/IDBClient.cpp (right):

https://codereview.chromium.org/148253005/diff/40001/Source/modules/indexeddb...
Source/modules/indexeddb/IDBClient.cpp:29: OwnPtr<InspectorIndexedDBAgent>
inspectorAgent =
InspectorIndexedDBAgent::create(inspectorController.injectedScriptManager(),
inspectorController.pageAgent());
Removed InjectedScriptManager dependency from InspectorIndexedDBAgent.

On 2014/02/05 12:32:07, pfeldman wrote:
> Inspector agents are private to inspector subsystem.

https://codereview.chromium.org/148253005/diff/40001/Source/modules/indexeddb...
File Source/modules/indexeddb/IDBClient.h (right):

https://codereview.chromium.org/148253005/diff/40001/Source/modules/indexeddb...
Source/modules/indexeddb/IDBClient.h:14: class IndexedDBClient : public
Supplement<Page> {
Removed this class completely.

On 2014/02/05 12:32:07, pfeldman wrote:
> This is not really a client - you don't use it to communicate from Blink to
> Chrome.

[pfeldman, 2014-02-06 11:33:47]

lgtm

https://chromiumcodereview.appspot.com/148253005/diff/110001/Source/devtools/...
File Source/devtools/protocol.json (right):

https://chromiumcodereview.appspot.com/148253005/diff/110001/Source/devtools/...
Source/devtools/protocol.json:1421: { "name": "key", "type": "string",
"description": "Key." },
JSON-stringified key object.

https://chromiumcodereview.appspot.com/148253005/diff/110001/Source/devtools/...
Source/devtools/protocol.json:1422: { "name": "primaryKey", "type": "string",
"description": "Primary key." },
ditto

https://chromiumcodereview.appspot.com/148253005/diff/110001/Source/devtools/...
Source/devtools/protocol.json:1423: { "name": "value", "type": "string",
"description": "Value." }
ditto

[Vladislav Kaznacheev, 2014-02-06 17:41:06]

The CQ bit was checked by kaznacheev@chromium.org

[commit-bot: I haz the power, 2014-02-06 17:41:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/148253005/160001

[commit-bot: I haz the power, 2014-02-06 17:41:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-06 17:41:32]

Failed to apply patch for Source/core/inspector/InspectorController.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/inspector/InspectorController.cpp
  Hunk #1 succeeded at 48 with fuzz 1 (offset -1 lines).
  Hunk #2 FAILED at 140.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/inspector/InspectorController.cpp.rej

Patch:       Source/core/inspector/InspectorController.cpp
Index: Source/core/inspector/InspectorController.cpp
diff --git a/Source/core/inspector/InspectorController.cpp
b/Source/core/inspector/InspectorController.cpp
index
22b342c7ca3c19eec57e247c165a1f7177c8a3f7..eece070f26148f4a613c3e66f324efc2f44c6791
100644
--- a/Source/core/inspector/InspectorController.cpp
+++ b/Source/core/inspector/InspectorController.cpp
@@ -49,7 +49,6 @@
 #include "core/inspector/InspectorFileSystemAgent.h"
 #include "core/inspector/InspectorFrontendClient.h"
 #include "core/inspector/InspectorHeapProfilerAgent.h"
-#include "core/inspector/InspectorIndexedDBAgent.h"
 #include "core/inspector/InspectorInputAgent.h"
 #include "core/inspector/InspectorInspectorAgent.h"
 #include "core/inspector/InspectorInstrumentation.h"
@@ -141,8 +140,6 @@ void InspectorController::initializeDeferredAgents()
 
     m_agents.append(InspectorCSSAgent::create(m_domAgent, m_pageAgent,
resourceAgent));
 
-    m_agents.append(InspectorIndexedDBAgent::create(injectedScriptManager,
m_pageAgent));
-
     m_agents.append(InspectorFileSystemAgent::create(m_pageAgent));
 
     m_agents.append(InspectorDOMStorageAgent::create(m_pageAgent));

[alecflett, 2014-02-06 23:28:58]

lgtm fwiw

[Vladislav Kaznacheev, 2014-02-07 08:01:06]

The CQ bit was checked by kaznacheev@chromium.org

[commit-bot: I haz the power, 2014-02-07 08:01:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/148253005/240001

[commit-bot: I haz the power, 2014-02-07 09:23:53]

Change committed as 166697

[vsevik, 2014-06-04 05:48:32]

https://codereview.chromium.org/148253005/diff/240001/Source/devtools/front_e...
File Source/devtools/front_end/IndexedDBModel.js (right):

https://codereview.chromium.org/148253005/diff/240001/Source/devtools/front_e...
Source/devtools/front_end/IndexedDBModel.js:382: var key =
WebInspector.RemoteObject.fromLocalObject(JSON.parse(dataEntries[i].key));
Now that we use LocalObject instead of RemoteObject, the .release() call is not
needed anymore for this objects.

FYI This patch together with the refactoring that removed release method from
the LocalObject broke paging in DevTools IndexedDB support.

https://codereview.chromium.org/148253005/diff/240001/Source/modules/indexedd...
File Source/modules/indexeddb/InspectorIndexedDBAgent.cpp (right):

https://codereview.chromium.org/148253005/diff/240001/Source/modules/indexedd...
Source/modules/indexeddb/InspectorIndexedDBAgent.cpp:451:
.setKey(idbCursor->key(context).toJSONValue(scriptState)->toJSONString())
With this change we need to transfer all the (potentially large) data stored in
the IndexedDB to front-end even if it is not really needed there.