third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js - Issue 2154103002: [DevTools] Remove toProtocolValue from v8_inspector/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js

Issue 2154103002: [DevTools] Remove toProtocolValue from v8_inspector/public. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js b/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js

index 23f74ae9a5c9b92572c6292e525994da16513ca9..76039648513d8263c2fc527e15e2e79aaf1f303e 100644

--- a/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBModel.js

@@ -419,9 +419,9 @@ WebInspector.IndexedDBModel.prototype = {

return;

var entries = [];

for (var i = 0; i < dataEntries.length; ++i) {

- var key = WebInspector.RemoteObject.fromLocalObject(JSON.parse(dataEntries[i].key));

- var primaryKey = WebInspector.RemoteObject.fromLocalObject(JSON.parse(dataEntries[i].primaryKey));

- var value = WebInspector.RemoteObject.fromLocalObject(JSON.parse(dataEntries[i].value));

+ var key = this.target().runtimeModel.createRemoteObject(dataEntries[i].key);

+ var primaryKey = this.target().runtimeModel.createRemoteObject(dataEntries[i].primaryKey);

+ var value = this.target().runtimeModel.createRemoteObject(dataEntries[i].value);

entries.push(new WebInspector.IndexedDBModel.Entry(key, primaryKey, value));

}

callback(entries, hasMore);