Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2153883002: [Mac/GN] Add missing files to some //remoting targets. (Closed)

Created:
4 years, 5 months ago by Robert Sesek
Modified:
4 years, 5 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org, nicholss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Add missing files to some //remoting targets. BUG=611859 R=sergeyu@chromium.org Committed: https://crrev.com/d281f458a9cb73ee335f3d0afda1d998d4db59c8 Cr-Commit-Position: refs/heads/master@{#405855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -7 lines) Patch
M remoting/host/BUILD.gn View 8 chunks +51 lines, -7 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Robert Sesek
4 years, 5 months ago (2016-07-15 17:29:10 UTC) #1
Sergey Ulanov
+nicholss@chromium.org lgtm
4 years, 5 months ago (2016-07-15 18:31:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153883002/1
4 years, 5 months ago (2016-07-15 19:03:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 20:55:28 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 20:56:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d281f458a9cb73ee335f3d0afda1d998d4db59c8
Cr-Commit-Position: refs/heads/master@{#405855}

Powered by Google App Engine
This is Rietveld 408576698