Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: remoting/host/BUILD.gn

Issue 2153883002: [Mac/GN] Add missing files to some //remoting targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/host/it2me/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/BUILD.gn
diff --git a/remoting/host/BUILD.gn b/remoting/host/BUILD.gn
index 4d67827e9fc3c3f459141790bd792c5a5f2d5c7f..5f26230f970f208d2df44aacee023e37978ba221 100644
--- a/remoting/host/BUILD.gn
+++ b/remoting/host/BUILD.gn
@@ -964,6 +964,29 @@ if (enable_me2me_host) {
]
}
}
+
+ mac_xib_bundle_data("remoting_host_xibs") {
+ sources = [
+ "disconnect_window.xib",
+ ]
+ }
+
+ bundle_data("remoting_host_resources") {
+ sources = [
+ "$root_gen_dir/remoting/CREDITS.txt",
+ "$root_out_dir/icudtl.dat",
+ "remoting_me2me_host.icns",
+ ]
+
+ outputs = [
+ "{{bundle_resources_dir}}/{{source_file_part}}",
+ ]
+
+ public_deps = [
+ ":credits",
+ "//third_party/icu:icudata",
+ ]
+ }
}
target(app_target_type, "remoting_me2me_host") {
@@ -998,6 +1021,8 @@ if (enable_me2me_host) {
]
}
deps += [
+ ":remoting_host_resources",
+ ":remoting_host_xibs",
":remoting_infoplist_strings",
"//remoting/resources:copy_locales",
]
@@ -1411,6 +1436,7 @@ if (enable_me2me_host) {
]
deps = [
+ ":remoting_host_uninstaller_resources",
":remoting_host_uninstaller_xibs",
":remoting_infoplist_strings",
"//base",
@@ -1422,9 +1448,17 @@ if (enable_me2me_host) {
mac_xib_bundle_data("remoting_host_uninstaller_xibs") {
sources = [
- #"installer/mac/uninstaller/remoting_uninstaller.icns",
"installer/mac/uninstaller/remoting_uninstaller.xib",
- #_uninstaller_plist
+ ]
+ }
+
+ bundle_data("remoting_host_uninstaller_resources") {
+ sources = [
+ "installer/mac/uninstaller/remoting_uninstaller.icns",
+ ]
+
+ outputs = [
+ "{{bundle_resources_dir}}/{{source_file_part}}",
]
}
@@ -1437,6 +1471,7 @@ if (enable_me2me_host) {
":remoting_host_prefpane",
":remoting_host_prefpane_bundle_data",
":remoting_host_prefpane_plist",
+ ":remoting_host_prefpane_resources",
":remoting_host_prefpane_xibs",
":remoting_infoplist_strings",
]
@@ -1454,7 +1489,17 @@ if (enable_me2me_host) {
"$root_build_dir/gen/remoting/host/remoting_host_prefpane",
]
outputs = [
- "{{bundle_executable_dir}}/remoting_host_prefname",
+ "{{bundle_executable_dir}}/{{source_file_part}}",
+ ]
+ }
+
+ bundle_data("remoting_host_prefpane_resources") {
+ sources = [
+ "//remoting/resources/chromoting128.png",
+ ]
+
+ outputs = [
+ "{{bundle_resources_dir}}/{{source_file_part}}",
]
}
@@ -1480,7 +1525,6 @@ if (enable_me2me_host) {
deps = [
":host",
- ":remoting_host_prefpane_xibs",
":remoting_infoplist_strings",
"//remoting/base",
"//remoting/resources:copy_locales",
@@ -1517,10 +1561,10 @@ if (enable_me2me_host) {
mac_xib_bundle_data("remoting_host_prefpane_xibs") {
sources = [
"mac/me2me_preference_pane.xib",
- #"mac/me2me_preference_pane_confirm_pin.xib",
- #"mac/me2me_preference_pane_disable.xib",
+ "mac/me2me_preference_pane_confirm_pin.xib",
+ "mac/me2me_preference_pane_disable.xib",
+
#"mac/me2me_preference_pane-Info.plist",
- #"//remoting/resources/chromoting128.png",
]
}
} else {
« no previous file with comments | « no previous file | remoting/host/it2me/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698