Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: remoting/host/BUILD.gn

Issue 2153883002: [Mac/GN] Add missing files to some //remoting targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | remoting/host/it2me/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 import("//build/config/win/manifest.gni") 7 import("//build/config/win/manifest.gni")
8 import("//build/util/version.gni") 8 import("//build/util/version.gni")
9 import("//chrome/version.gni") 9 import("//chrome/version.gni")
10 import("//remoting/remoting_enable.gni") 10 import("//remoting/remoting_enable.gni")
(...skipping 946 matching lines...) Expand 10 before | Expand all | Expand 10 after
957 "$root_gen_dir/remoting/host/remoting_me2me_host-InfoPlist.strings/$ locale.lproj/InfoPlist.strings", 957 "$root_gen_dir/remoting/host/remoting_me2me_host-InfoPlist.strings/$ locale.lproj/InfoPlist.strings",
958 ] 958 ]
959 outputs = [ 959 outputs = [
960 "{{bundle_resources_dir}}/$locale.lproj/{{source_file_part}}", 960 "{{bundle_resources_dir}}/$locale.lproj/{{source_file_part}}",
961 ] 961 ]
962 deps = [ 962 deps = [
963 ":remoting_infoplist_strings", 963 ":remoting_infoplist_strings",
964 ] 964 ]
965 } 965 }
966 } 966 }
967
968 mac_xib_bundle_data("remoting_host_xibs") {
969 sources = [
970 "disconnect_window.xib",
971 ]
972 }
973
974 bundle_data("remoting_host_resources") {
975 sources = [
976 "$root_gen_dir/remoting/CREDITS.txt",
977 "$root_out_dir/icudtl.dat",
978 "remoting_me2me_host.icns",
979 ]
980
981 outputs = [
982 "{{bundle_resources_dir}}/{{source_file_part}}",
983 ]
984
985 public_deps = [
986 ":credits",
987 "//third_party/icu:icudata",
988 ]
989 }
967 } 990 }
968 991
969 target(app_target_type, "remoting_me2me_host") { 992 target(app_target_type, "remoting_me2me_host") {
970 if (is_mac) { 993 if (is_mac) {
971 extra_configs = [ "//remoting:version" ] 994 extra_configs = [ "//remoting:version" ]
972 info_plist = "remoting_me2me_host-Info.plist" 995 info_plist = "remoting_me2me_host-Info.plist"
973 } else { 996 } else {
974 configs += [ "//remoting:version" ] 997 configs += [ "//remoting:version" ]
975 } 998 }
976 999
(...skipping 14 matching lines...) Expand all
991 "//remoting/resources", 1014 "//remoting/resources",
992 ] 1015 ]
993 if (is_mac) { 1016 if (is_mac) {
994 foreach(locale, remoting_locales_with_underscores) { 1017 foreach(locale, remoting_locales_with_underscores) {
995 deps += [ 1018 deps += [
996 ":remoting_host_locale_${locale}_bundle_data", 1019 ":remoting_host_locale_${locale}_bundle_data",
997 ":remoting_me2me_host_strings_${locale}_bundle_data", 1020 ":remoting_me2me_host_strings_${locale}_bundle_data",
998 ] 1021 ]
999 } 1022 }
1000 deps += [ 1023 deps += [
1024 ":remoting_host_resources",
1025 ":remoting_host_xibs",
1001 ":remoting_infoplist_strings", 1026 ":remoting_infoplist_strings",
1002 "//remoting/resources:copy_locales", 1027 "//remoting/resources:copy_locales",
1003 ] 1028 ]
1004 } 1029 }
1005 } 1030 }
1006 1031
1007 if (is_linux) { 1032 if (is_linux) {
1008 copy("remoting_me2me_host_copy_script") { 1033 copy("remoting_me2me_host_copy_script") {
1009 sources = [ 1034 sources = [
1010 "linux/linux_me2me_host.py", 1035 "linux/linux_me2me_host.py",
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
1404 "installer/mac/uninstaller/remoting_uninstaller_app.mm", 1429 "installer/mac/uninstaller/remoting_uninstaller_app.mm",
1405 ] 1430 ]
1406 1431
1407 libs = [ 1432 libs = [
1408 "Cocoa.framework", 1433 "Cocoa.framework",
1409 "CoreFoundation.framework", 1434 "CoreFoundation.framework",
1410 "Security.framework", 1435 "Security.framework",
1411 ] 1436 ]
1412 1437
1413 deps = [ 1438 deps = [
1439 ":remoting_host_uninstaller_resources",
1414 ":remoting_host_uninstaller_xibs", 1440 ":remoting_host_uninstaller_xibs",
1415 ":remoting_infoplist_strings", 1441 ":remoting_infoplist_strings",
1416 "//base", 1442 "//base",
1417 ] 1443 ]
1418 foreach(locale, remoting_locales_with_underscores) { 1444 foreach(locale, remoting_locales_with_underscores) {
1419 deps += [ ":remoting_uninstaller_strings_${locale}_bundle_data" ] 1445 deps += [ ":remoting_uninstaller_strings_${locale}_bundle_data" ]
1420 } 1446 }
1421 } 1447 }
1422 1448
1423 mac_xib_bundle_data("remoting_host_uninstaller_xibs") { 1449 mac_xib_bundle_data("remoting_host_uninstaller_xibs") {
1424 sources = [ 1450 sources = [
1425 #"installer/mac/uninstaller/remoting_uninstaller.icns",
1426 "installer/mac/uninstaller/remoting_uninstaller.xib", 1451 "installer/mac/uninstaller/remoting_uninstaller.xib",
1427 #_uninstaller_plist
1428 ] 1452 ]
1429 } 1453 }
1430 1454
1455 bundle_data("remoting_host_uninstaller_resources") {
1456 sources = [
1457 "installer/mac/uninstaller/remoting_uninstaller.icns",
1458 ]
1459
1460 outputs = [
1461 "{{bundle_resources_dir}}/{{source_file_part}}",
1462 ]
1463 }
1464
1431 create_bundle("remoting_host_prefpane.prefPane") { 1465 create_bundle("remoting_host_prefpane.prefPane") {
1432 bundle_root_dir = "$root_build_dir/$target_name/Contents" 1466 bundle_root_dir = "$root_build_dir/$target_name/Contents"
1433 bundle_resources_dir = bundle_root_dir + "/Resources" 1467 bundle_resources_dir = bundle_root_dir + "/Resources"
1434 bundle_executable_dir = bundle_root_dir + "/MacOS" 1468 bundle_executable_dir = bundle_root_dir + "/MacOS"
1435 1469
1436 deps = [ 1470 deps = [
1437 ":remoting_host_prefpane", 1471 ":remoting_host_prefpane",
1438 ":remoting_host_prefpane_bundle_data", 1472 ":remoting_host_prefpane_bundle_data",
1439 ":remoting_host_prefpane_plist", 1473 ":remoting_host_prefpane_plist",
1474 ":remoting_host_prefpane_resources",
1440 ":remoting_host_prefpane_xibs", 1475 ":remoting_host_prefpane_xibs",
1441 ":remoting_infoplist_strings", 1476 ":remoting_infoplist_strings",
1442 ] 1477 ]
1443 1478
1444 foreach(locale, remoting_locales_with_underscores) { 1479 foreach(locale, remoting_locales_with_underscores) {
1445 deps += [ ":remoting_host_prefpane_strings_${locale}_bundle_data" ] 1480 deps += [ ":remoting_host_prefpane_strings_${locale}_bundle_data" ]
1446 } 1481 }
1447 } 1482 }
1448 1483
1449 bundle_data("remoting_host_prefpane_bundle_data") { 1484 bundle_data("remoting_host_prefpane_bundle_data") {
1450 deps = [ 1485 deps = [
1451 ":remoting_host_prefpane", 1486 ":remoting_host_prefpane",
1452 ] 1487 ]
1453 sources = [ 1488 sources = [
1454 "$root_build_dir/gen/remoting/host/remoting_host_prefpane", 1489 "$root_build_dir/gen/remoting/host/remoting_host_prefpane",
1455 ] 1490 ]
1456 outputs = [ 1491 outputs = [
1457 "{{bundle_executable_dir}}/remoting_host_prefname", 1492 "{{bundle_executable_dir}}/{{source_file_part}}",
1458 ] 1493 ]
1459 } 1494 }
1460 1495
1496 bundle_data("remoting_host_prefpane_resources") {
1497 sources = [
1498 "//remoting/resources/chromoting128.png",
1499 ]
1500
1501 outputs = [
1502 "{{bundle_resources_dir}}/{{source_file_part}}",
1503 ]
1504 }
1505
1461 loadable_module("remoting_host_prefpane") { 1506 loadable_module("remoting_host_prefpane") {
1462 output_dir = "$root_out_dir/gen/remoting/host" 1507 output_dir = "$root_out_dir/gen/remoting/host"
1463 output_extension = "" 1508 output_extension = ""
1464 1509
1465 sources = [ 1510 sources = [
1466 "mac/me2me_preference_pane.h", 1511 "mac/me2me_preference_pane.h",
1467 "mac/me2me_preference_pane.mm", 1512 "mac/me2me_preference_pane.mm",
1468 "mac/me2me_preference_pane_confirm_pin.h", 1513 "mac/me2me_preference_pane_confirm_pin.h",
1469 "mac/me2me_preference_pane_confirm_pin.mm", 1514 "mac/me2me_preference_pane_confirm_pin.mm",
1470 "mac/me2me_preference_pane_disable.h", 1515 "mac/me2me_preference_pane_disable.h",
1471 "mac/me2me_preference_pane_disable.mm", 1516 "mac/me2me_preference_pane_disable.mm",
1472 ] 1517 ]
1473 1518
1474 libs = [ 1519 libs = [
1475 "Cocoa.framework", 1520 "Cocoa.framework",
1476 "CoreFoundation.framework", 1521 "CoreFoundation.framework",
1477 "PreferencePanes.framework", 1522 "PreferencePanes.framework",
1478 "Security.framework", 1523 "Security.framework",
1479 ] 1524 ]
1480 1525
1481 deps = [ 1526 deps = [
1482 ":host", 1527 ":host",
1483 ":remoting_host_prefpane_xibs",
1484 ":remoting_infoplist_strings", 1528 ":remoting_infoplist_strings",
1485 "//remoting/base", 1529 "//remoting/base",
1486 "//remoting/resources:copy_locales", 1530 "//remoting/resources:copy_locales",
1487 "//third_party/jsoncpp", 1531 "//third_party/jsoncpp",
1488 ] 1532 ]
1489 foreach(locale, remoting_locales_with_underscores) { 1533 foreach(locale, remoting_locales_with_underscores) {
1490 deps += [ ":remoting_host_prefpane_strings_${locale}_bundle_data" ] 1534 deps += [ ":remoting_host_prefpane_strings_${locale}_bundle_data" ]
1491 } 1535 }
1492 } 1536 }
1493 1537
(...skipping 16 matching lines...) Expand all
1510 ] 1554 ]
1511 deps = [ 1555 deps = [
1512 ":remoting_infoplist_strings", 1556 ":remoting_infoplist_strings",
1513 ] 1557 ]
1514 } 1558 }
1515 } 1559 }
1516 1560
1517 mac_xib_bundle_data("remoting_host_prefpane_xibs") { 1561 mac_xib_bundle_data("remoting_host_prefpane_xibs") {
1518 sources = [ 1562 sources = [
1519 "mac/me2me_preference_pane.xib", 1563 "mac/me2me_preference_pane.xib",
1520 #"mac/me2me_preference_pane_confirm_pin.xib", 1564 "mac/me2me_preference_pane_confirm_pin.xib",
1521 #"mac/me2me_preference_pane_disable.xib", 1565 "mac/me2me_preference_pane_disable.xib",
1566
1522 #"mac/me2me_preference_pane-Info.plist", 1567 #"mac/me2me_preference_pane-Info.plist",
1523 #"//remoting/resources/chromoting128.png",
1524 ] 1568 ]
1525 } 1569 }
1526 } else { 1570 } else {
1527 group("remoting_me2me_host_archive") { 1571 group("remoting_me2me_host_archive") {
1528 } 1572 }
1529 } 1573 }
1530 1574
1531 if (is_win && is_chrome_branded) { 1575 if (is_win && is_chrome_branded) {
1532 # We do not release a 64 bits binary. So to avoid any potential 1576 # We do not release a 64 bits binary. So to avoid any potential
1533 # misunderstanding, we only build 32 bits MSI file. 1577 # misunderstanding, we only build 32 bits MSI file.
(...skipping 21 matching lines...) Expand all
1555 root_build_dir), 1599 root_build_dir),
1556 rebase_path(outputs[0], root_build_dir), 1600 rebase_path(outputs[0], root_build_dir),
1557 ] 1601 ]
1558 } 1602 }
1559 } else { 1603 } else {
1560 group("remoting_host_installation") { 1604 group("remoting_host_installation") {
1561 } 1605 }
1562 } 1606 }
1563 } 1607 }
1564 } 1608 }
OLDNEW
« no previous file with comments | « no previous file | remoting/host/it2me/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698