Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1695)

Unified Diff: chrome/browser/permissions/permission_uma_util.cc

Issue 2153763002: Add user gesture field to permission report (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-source-ui-to-permission-report
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_uma_util.cc
diff --git a/chrome/browser/permissions/permission_uma_util.cc b/chrome/browser/permissions/permission_uma_util.cc
index 7eae053925997d1ba44594934e964669537d0829..0206a20695e3b9d491a9a99ad443ee881136847c 100644
--- a/chrome/browser/permissions/permission_uma_util.cc
+++ b/chrome/browser/permissions/permission_uma_util.cc
@@ -339,10 +339,11 @@ void PermissionUmaUtil::RecordPermissionAction(PermissionType permission,
if (IsOptedIntoPermissionActionReporting(profile)) {
// TODO(stefanocs): Add browsertests to make sure the reports are being
// sent.
+ // TODO(stefanocs): Get the actual |user_gesture| from permission layer.
g_browser_process->safe_browsing_service()
->ui_manager()
->ReportPermissionAction(requesting_origin, permission, action,
- source_ui);
+ source_ui, false);
raymes 2016/07/18 00:31:25 Rather than using a bool, it's probably better to
raymes 2016/07/18 00:35:11 I see most of the other code just uses a bool for
stefanocs 2016/07/18 00:48:07 Done. I was planning on doing this before but I wa
}
bool secure_origin = content::IsOriginSecure(requesting_origin);

Powered by Google App Engine
This is Rietveld 408576698