Add user gesture field to permission report

chrome/browser/permissions/permission_uma_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_uma_util.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 321 matching lines @@
 }
 
 void PermissionUmaUtil::RecordPermissionAction(PermissionType permission,
                                                PermissionAction action,
                                                PermissionSourceUI source_ui,
                                                const GURL& requesting_origin,
                                                Profile* profile) {
   if (IsOptedIntoPermissionActionReporting(profile)) {
     // TODO(stefanocs): Add browsertests to make sure the reports are being
     // sent.
+    // TODO(stefanocs): Get the actual |user_gesture| from permission layer.
     g_browser_process->safe_browsing_service()
         ->ui_manager()
         ->ReportPermissionAction(requesting_origin, permission, action,
-                                 source_ui);
+                                 source_ui, false);

[raymes, 2016/07/18 00:31:25]

Rather than using a bool, it's probably better to define an enum. This serves as
documentation of what the argument is for (rather than just true/false).

[raymes, 2016/07/18 00:35:11]

I see most of the other code just uses a bool for this, so I'm ok sticking with
a bool. But we need to include inline comments denoting what the argument is.
e.g. in this case, it would be:

, false /* user_gesture */);

[stefanocs, 2016/07/18 00:48:07]

Done. I was planning on doing this before but I wasn't clear whether to use
vector<RequestTrigger> or just RequestTrigger and since most of the code in
permission layer uses bool, I wasn't sure where we going to convert it into a
request trigger. So I decided to stick with this first.

   }
 
   bool secure_origin = content::IsOriginSecure(requesting_origin);
 
   switch (permission) {
     case PermissionType::GEOLOCATION:
       PERMISSION_ACTION_UMA(secure_origin, "Permissions.Action.Geolocation",
                             "Permissions.Action.SecureOrigin.Geolocation",
                             "Permissions.Action.InsecureOrigin.Geolocation",
                             action);
@@ skipping 59 matching lines @@
   if (!deprecated_metric.empty() && rappor_service) {
     rappor::SampleDomainAndRegistryFromGURL(rappor_service, deprecated_metric,
                                             requesting_origin);
 
     std::string rappor_metric = deprecated_metric + "2";
     rappor_service->RecordSample(
         rappor_metric, rappor::LOW_FREQUENCY_ETLD_PLUS_ONE_RAPPOR_TYPE,
         rappor::GetDomainAndRegistrySampleFromGURL(requesting_origin));
   }
 }