Add user gesture field to permission report

chrome/browser/safe_browsing/permission_reporter_unittest.cc

Index: chrome/browser/safe_browsing/permission_reporter_unittest.cc
diff --git a/chrome/browser/safe_browsing/permission_reporter_unittest.cc b/chrome/browser/safe_browsing/permission_reporter_unittest.cc
index cb2ae72b15bde05007a8d620782c2dec4422bf2f..6d8d18ac30456959c0f441a6be381500a4df072f 100644
--- a/chrome/browser/safe_browsing/permission_reporter_unittest.cc
+++ b/chrome/browser/safe_browsing/permission_reporter_unittest.cc
@@ -85,7 +85,7 @@ class PermissionReporterTest : public ::testing::Test {
 // SafeBrowsing CSD servers.
 TEST_F(PermissionReporterTest, SendReport) {
   permission_reporter_->SendReport(GURL(kDummyOrigin), kDummyPermission,
-                                   kDummyAction, kDummySourceUI);
+                                   kDummyAction, kDummySourceUI, false);
 
   PermissionReport permission_report;
   ASSERT_TRUE(
@@ -94,6 +94,7 @@ TEST_F(PermissionReporterTest, SendReport) {
   EXPECT_EQ(PermissionReport::GRANTED, permission_report.action());
   EXPECT_EQ(PermissionReport::PROMPT, permission_report.source_ui());
   EXPECT_EQ(kDummyOrigin, permission_report.origin());
+  EXPECT_TRUE(permission_report.request_trigger().empty());
 #if defined(OS_ANDROID)
   EXPECT_EQ(PermissionReport::ANDROID_PLATFORM,
             permission_report.platform_type());
@@ -108,6 +109,20 @@ TEST_F(PermissionReporterTest, SendReport) {
 }
 
 // Test that PermissionReporter::SendReport sends a serialized report string
+// with request trigger to SafeBrowsing CSD servers.
+TEST_F(PermissionReporterTest, SendReportWithRequestTrigger) {
+  permission_reporter_->SendReport(GURL(kDummyOrigin), kDummyPermission,
+                                   kDummyAction, kDummySourceUI, true);
+
+  PermissionReport permission_report;
+  ASSERT_TRUE(
+      permission_report.ParseFromString(mock_report_sender_->latest_report()));
+  EXPECT_EQ(PermissionReport::AFTER_GESTURE,
+            static_cast<PermissionReport::RequestTrigger>(
+                permission_report.request_trigger(0)));

[raymes, 2016/07/18 00:31:25]

Can we check that the number of these is 0? 

Is it necessary to cast this value?

[stefanocs, 2016/07/18 00:48:07]

Do you mean check the size of request trigger == 1?

permission_report.request_trigger(0) returns an int, should I check for the int
value instead?

[kcarattini, 2016/07/18 01:00:04]

Yes, you should check this as well.

[stefanocs, 2016/07/18 03:48:53]

Done.

[raymes, 2016/07/18 07:18:14]

Sorry, yes I said 0 but I meant 1 :)

+}
+
+// Test that PermissionReporter::SendReport sends a serialized report string
 // with field trials to SafeBrowsing CSD servers.
 TEST_F(PermissionReporterTest, SendReportWithFieldTrials) {
   typedef std::set<variations::ActiveGroupId, variations::ActiveGroupIdCompare>
@@ -139,7 +154,7 @@ TEST_F(PermissionReporterTest, SendReportWithFieldTrials) {
   EXPECT_TRUE(base::FieldTrialList::IsTrialActive(trial_two->trial_name()));
 
   permission_reporter_->SendReport(GURL(kDummyOrigin), kDummyPermission,
-                                   kDummyAction, kDummySourceUI);
+                                   kDummyAction, kDummySourceUI, false);
 
   PermissionReport permission_report;
   ASSERT_TRUE(