Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2153153003: DevTools: remove dead code, disambiguate expand for sections. (Closed)

Created:
4 years, 5 months ago by pfeldman
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, blink-reviews-style_chromium.org, aboxhall, aboxhall+watch_chromium.org, nektar+watch_chromium.org, je_julie, lushnikov+blink_chromium.org, yuzo+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dmazzoni, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove dead code, disambiguate expand for sections. BUG=627306 Committed: https://crrev.com/f654e09cc67f3ab30656a27e5d7647546cdd08d4 Cr-Commit-Position: refs/heads/master@{#406071}

Patch Set 1 #

Patch Set 2 : lcean #

Patch Set 3 : lcean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -421 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-events.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/error-in-watch-expressions.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-panel-switch.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/AuditResultView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/Section.js View 1 chunk +0 lines, -180 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SidebarPane.js View 4 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/module.json View 2 chunks +0 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/propertiesSection.css View 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/section.css View 1 chunk +0 lines, -81 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
pfeldman
4 years, 5 months ago (2016-07-15 18:26:20 UTC) #2
dgozman
lgtm
4 years, 5 months ago (2016-07-15 21:52:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153153003/20001
4 years, 5 months ago (2016-07-15 22:08:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/246096)
4 years, 5 months ago (2016-07-15 23:16:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153153003/40001
4 years, 5 months ago (2016-07-16 01:32:12 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/263933)
4 years, 5 months ago (2016-07-16 03:59:13 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2153153003/40001
4 years, 5 months ago (2016-07-18 18:21:28 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-18 19:58:55 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 19:59:19 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 20:00:37 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f654e09cc67f3ab30656a27e5d7647546cdd08d4
Cr-Commit-Position: refs/heads/master@{#406071}

Powered by Google App Engine
This is Rietveld 408576698