third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js - Issue 2153153003: DevTools: remove dead code, disambiguate expand for sections.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2153153003: DevTools: remove dead code, disambiguate expand for sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

index 110584831c4d814b0692b41b3ab9597394e15ab0..756bdd6b5a7f5bbebb4da679142f93d32293c085 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

@@ -87,7 +87,7 @@ WebInspector.SourcesPanel = function(workspaceForTest)

this.sidebarPanes.eventListenerBreakpoints = new WebInspector.EventListenerBreakpointsSidebarPane();

this.sidebarPanes.objectEventListeners = new WebInspector.ObjectEventListenersSidebarPane();

- this._lastSelectedTabSetting = WebInspector.settings.createLocalSetting("lastSelectedSourcesSidebarPaneTab", this.sidebarPanes.scopechain.title());

+ this._lastSelectedTabSetting = WebInspector.settings.createLocalSetting("lastSelectedSourcesSidebarPaneTab", WebInspector.UIString("Scope"));

this._installDebuggerSidebarController();

@@ -1104,7 +1104,7 @@ WebInspector.SourcesPanel.prototype = {

this._extensionSidebarPanesContainer = sidebarPaneStack;

this.sidebarPaneView = vbox;

- this.sidebarPanes.scopechain.expand();

+ this.sidebarPanes.scopechain.expandPane();

this.sidebarPanes.watchExpressions.expandIfNecessary();

} else {

var splitWidget = new WebInspector.SplitWidget(true, true, "sourcesPanelDebuggerSidebarSplitViewState", 0.5);

@@ -1136,9 +1136,9 @@ WebInspector.SourcesPanel.prototype = {

this._addExtensionSidebarPane(extensionSidebarPanes[i]);

this._splitWidget.setSidebarWidget(this.sidebarPaneView);

- this.sidebarPanes.threads.expand();

- this.sidebarPanes.jsBreakpoints.expand();

- this.sidebarPanes.callstack.expand();

+ this.sidebarPanes.threads.expandPane();

+ this.sidebarPanes.jsBreakpoints.expandPane();

+ this.sidebarPanes.callstack.expandPane();

/**